Page MenuHomeFreeBSD
Differential D4683

sys/kern/kern_resource.c: fold lim_shared into lim_copy to mute -Wunused compiler warnings from clang with !INVARIANTS
ClosedPublic
Actions

Authored by ngie on Dec 22 2015, 7:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 6:13 PM
Unknown Object (File)
Fri, Apr 26, 6:13 PM
Unknown Object (File)
Fri, Apr 26, 6:13 PM
Unknown Object (File)
Fri, Apr 26, 2:00 PM
Unknown Object (File)
Fri, Apr 26, 1:35 PM
Unknown Object (File)
Tue, Apr 23, 2:46 PM
Unknown Object (File)
Mar 10 2024, 5:12 AM
Unknown Object (File)
Mar 10 2024, 5:12 AM
View All 62 Files
Subscribers
imp
jhb
kib

Details

Reviewers
kib
mjg
Commits
rS292626: Fold lim_shared into lim_copy to mute a -Wunused compiler warning from
Summary

Fold lim_shared into lim_copy to mute -Wunused compiler warnings from clang when
the kernel is compiled without INVARIANTS

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie updated this revision to Diff 11606.Dec 22 2015, 7:24 PM
ngie retitled this revision from to sys/kern/kern_resource.c: only expose lim_shared when INVARIANTS is enabled to mute -Wunused compiler warnings from clang.
ngie updated this object.
ngie edited the test plan for this revision. (Show Details)
ngie added a reviewer: mjg.
ngie set the repository for this revision to rS FreeBSD src repository - subversion.
ngie added subscribers: jhb, kib.
Herald added a subscriber: imp. · View Herald TranscriptDec 22 2015, 7:24 PM
ngie updated this object.Dec 22 2015, 7:24 PM
kib added a comment.Dec 22 2015, 7:54 PM

Why not inline the test into KASSERT() and get rid if lim_shared() ? It is not used otherwise and would save ten lines of code.

ngie added a comment.Dec 22 2015, 8:10 PM
In D4683#98845, @kib wrote:

Why not inline the test into KASSERT() and get rid if lim_shared() ? It is not used otherwise and would save ten lines of code.

Yeah, my gut said do that too, but I wasn't sure if mjg had used the function elsewhere.

I'll go ahead and do that.

jhb added inline comments.Dec 22 2015, 8:12 PM
sys/kern/kern_resource.c
1150 ↗(On Diff #11606)

Also, there is no need for #ifdef INVARIANTS around a single KASSERT(). That is redundant.

ngie updated this revision to Diff 11612.Dec 22 2015, 8:13 PM
ngie retitled this revision from sys/kern/kern_resource.c: only expose lim_shared when INVARIANTS is enabled to mute -Wunused compiler warnings from clang to sys/kern/kern_resource.c: fold lim_shared into lim_copy to mute -Wunused compiler warnings from clang with !INVARIANTS.
ngie updated this object.
ngie marked an inline comment as done.
ngie added inline comments.
sys/kern/kern_resource.c
1143 ↗(On Diff #11612)

I'll have to double check whether or not this would result in a compiler error because it couldn't look up the symbol for lim_shared.

Both cases have been fixed by completely inlining lim_shared into lim_copy :).

ngie marked 2 inline comments as done.Dec 22 2015, 8:15 PM
kib accepted this revision.Dec 22 2015, 8:41 PM
kib added a reviewer: kib.
This revision is now accepted and ready to land.Dec 22 2015, 8:41 PM
Closed by commit rS292626: Fold lim_shared into lim_copy to mute a -Wunused compiler warning from (authored by ngie). · Explain WhyDec 22 2015, 9:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
11 lines

Diff 11617

View Options

head/sys/kern/kern_resource.c

Loading...