Page MenuHomeFreeBSD

git-arc: Fix find_author() for external users
ClosedPublic

Authored by jlduran on Sep 25 2024, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 9, 1:03 PM
Unknown Object (File)
Sat, May 9, 1:03 PM
Unknown Object (File)
Fri, May 8, 7:45 AM
Unknown Object (File)
Apr 28 2026, 4:30 AM
Unknown Object (File)
Apr 27 2026, 5:52 PM
Unknown Object (File)
Apr 18 2026, 6:10 PM
Unknown Object (File)
Apr 18 2026, 6:10 PM
Unknown Object (File)
Apr 18 2026, 6:10 PM
Subscribers
None

Details

Summary

When an external user submits a review in Phabricator, the find_author()
subroutine may receive the author_name and author_addr as "null" from
the JSON API with git-arc patch.

This "null" string gets tested for length by "[ -n", and returning that
is greater than zero, in other words, the shell does not understand that
"null" means nothing in this case.

Fix it by adding a guard, that sets an empty string when the content is
"null".

While here, standardize the indentation style for find_author()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable