Page MenuHomeFreeBSD

git-arc: Fix find_author() for external users
ClosedPublic

Authored by jlduran on Sep 25 2024, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 5, 8:42 AM
Unknown Object (File)
Sun, Oct 4, 5:59 PM
Unknown Object (File)
Thu, Oct 1, 8:30 PM
Unknown Object (File)
Sat, Sep 26, 2:10 PM
Unknown Object (File)
Tue, Sep 22, 9:01 PM
Unknown Object (File)
Tue, Sep 22, 8:57 PM
Unknown Object (File)
Tue, Sep 22, 5:45 PM
Unknown Object (File)
Thu, Sep 10, 6:55 AM
Subscribers
None

Details

Summary

When an external user submits a review in Phabricator, the find_author()
subroutine may receive the author_name and author_addr as "null" from
the JSON API with git-arc patch.

This "null" string gets tested for length by "[ -n", and returning that
is greater than zero, in other words, the shell does not understand that
"null" means nothing in this case.

Fix it by adding a guard, that sets an empty string when the content is
"null".

While here, standardize the indentation style for find_author()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable