Page MenuHomeFreeBSD

git-arc: Fix find_author() for external users
ClosedPublic

Authored by jlduran on Sep 25 2024, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 2:59 AM
Unknown Object (File)
Wed, Aug 12, 11:35 PM
Unknown Object (File)
Wed, Aug 12, 2:06 PM
Unknown Object (File)
Wed, Aug 12, 2:06 PM
Unknown Object (File)
Wed, Aug 12, 2:04 PM
Unknown Object (File)
Wed, Aug 12, 8:50 AM
Unknown Object (File)
Tue, Aug 11, 9:53 AM
Unknown Object (File)
Mon, Aug 10, 10:07 PM
Subscribers
None

Details

Summary

When an external user submits a review in Phabricator, the find_author()
subroutine may receive the author_name and author_addr as "null" from
the JSON API with git-arc patch.

This "null" string gets tested for length by "[ -n", and returning that
is greater than zero, in other words, the shell does not understand that
"null" means nothing in this case.

Fix it by adding a guard, that sets an empty string when the content is
"null".

While here, standardize the indentation style for find_author()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable