Page MenuHomeFreeBSD

git-arc: Fix find_author() for external users
ClosedPublic

Authored by jlduran on Sep 25 2024, 5:44 PM.
Tags
None
Referenced Files
F171080637: D46789.id146033.diff
Tue, Sep 8, 2:21 PM
Unknown Object (File)
Mon, Sep 7, 8:36 AM
Unknown Object (File)
Sun, Sep 6, 1:05 PM
Unknown Object (File)
Sat, Sep 5, 5:32 PM
Unknown Object (File)
Sat, Sep 5, 12:29 AM
Unknown Object (File)
Fri, Sep 4, 10:40 PM
Unknown Object (File)
Fri, Sep 4, 10:33 PM
Unknown Object (File)
Thu, Sep 3, 2:26 PM
Subscribers
None

Details

Summary

When an external user submits a review in Phabricator, the find_author()
subroutine may receive the author_name and author_addr as "null" from
the JSON API with git-arc patch.

This "null" string gets tested for length by "[ -n", and returning that
is greater than zero, in other words, the shell does not understand that
"null" means nothing in this case.

Fix it by adding a guard, that sets an empty string when the content is
"null".

While here, standardize the indentation style for find_author()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable