Remap UART physical address with OF_decode_addr()
ClosedPublic
Actions

Authored by • ian on Dec 22 2015, 1:33 AM.

Details

Reviewers

andrew
bsz_semihalf.com

Group Reviewers

ARM

Commits

rS294280: Use OF_decode_addr() to create a bus_space tag and handle for the console

Summary

After the refactoring of the powerpc code so that OF_decode_addr() is usable on all FDT/OFW platforms, switch uart(4) to using it to set up console access.

This supercedes D4217.

Test Plan

Tested on imx6 and kirkwood.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• ian updated this revision to Diff 11546.Dec 22 2015, 1:33 AM

• ian retitled this revision from to Remap UART physical address with OF_decode_addr().

• ian updated this object.

• ian edited the test plan for this revision. (Show Details)

• ian added reviewers: bsz_semihalf.com, ARM.

• ian set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 22 2015, 1:33 AM

• ian mentioned this in D4217: Remap UART physical address through simple-bus ranges.Dec 22 2015, 1:36 AM

This fails to link on arm64:

linking kernel.full
uart_cpu_fdt.o: In function `uart_cpu_getdev':
/home/at718/freebsd/sys/dev/uart/uart_cpu_fdt.c:215: undefined reference to `OF_decode_addr'

This revision now requires changes to proceed.Dec 22 2015, 7:28 AM

Works fine for me, thank you! As for Andrew's issue, perhaps we could add sys/arm/arm/ofw_machdep.c to sys/conf/files.arm64?

In D4675#98635, @bsz_semihalf.com wrote:

Works fine for me, thank you! As for Andrew's issue, perhaps we could add sys/arm/arm/ofw_machdep.c to sys/conf/files.arm64?

This was done in r293060, but I forgot to cite the phab in the commit msg.

I think the reset of the semihalf chagnes that were depending on this are ready to move forward.

From our Comedy Of Errors Dept: un-abandon this, I abandoned the wrong diff, citing the wrong svn rev. Proper commit and close to follow.

This revision now requires changes to proceed.Jan 18 2016, 4:46 PM

Closed by commit rS294280: Use OF_decode_addr() to create a bus_space tag and handle for the console (authored by • ian). · Explain WhyJan 18 2016, 5:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

uart/

uart_cpu_fdt.c

13 lines

Diff 12429

View Options

head/sys/dev/uart/uart_cpu_fdt.c

Remap UART physical address with OF_decode_addr()ClosedPublicActions