Page MenuHomeFreeBSD

malloc: Check for overflow when rounding up to the page size
Needs ReviewPublic

Authored by markj on Jul 24 2024, 9:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 27, 5:19 PM
Unknown Object (File)
Sun, Apr 19, 12:13 AM
Unknown Object (File)
Sat, Apr 18, 5:58 PM
Unknown Object (File)
Fri, Apr 17, 12:38 PM
Unknown Object (File)
Sun, Apr 12, 6:41 PM
Unknown Object (File)
Mar 18 2026, 11:28 PM
Unknown Object (File)
Mar 18 2026, 11:23 PM
Unknown Object (File)
Mar 17 2026, 3:14 AM
Subscribers

Details

Reviewers
dougm

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58808
Build 55695: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jul 24 2024, 9:31 PM
sys/kern/kern_malloc.c
1140

Just return size.

1141

If PAGE_SHIFT >= KMEM_ZSHIFT (which is 4), then updating size with KMEM_ZMASK and ZMEM_ZBASE is a no-op. And I imagine that you can assume PAGE_SHIFT >= 4. So you can drop 2 lines here.

1141

This condition is now always false, since PAGE_SHIFT >= KMEM_ZSHIFT.

sys/kern/kern_malloc.c
612

This change uses _size and size for the unaligned and aligned size values. The next patch uses size and asize for those values. Consistency would be good.