socket: Make soref() assert that so_count > 0
Needs ReviewPublic
Actions

Authored by markj on Jul 8 2024, 4:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 3, 8:06 AM

	Unknown Object (File)
	Wed, Oct 2, 6:11 AM

	Unknown Object (File)
	Mon, Sep 30, 11:11 PM

	Unknown Object (File)
	Mon, Sep 23, 7:44 PM

	Unknown Object (File)
	Sun, Sep 22, 7:53 AM

	Unknown Object (File)
	Sat, Sep 21, 3:51 AM

	Unknown Object (File)
	Fri, Sep 20, 7:46 AM

	Unknown Object (File)
	Thu, Sep 19, 3:35 AM

View All 24 Files

Subscribers

imp

olce

Details

Reviewers

glebius

Summary

This might help catch some bugs. socreate() currently violates this
assertion, so initialize its refcount manually (and without an atomic
instruction) before attaching to the protocol.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58920
Build 55807: arc lint + arc unit

Event Timeline

markj created this revision.Jul 8 2024, 4:25 PM

Herald added subscribers: olce, imp. · View Herald TranscriptJul 8 2024, 4:25 PM

markj requested review of this revision.Jul 8 2024, 4:25 PM

Harbormaster completed remote builds in B58570: Diff 140699.Jul 8 2024, 4:25 PM

glebius accepted this revision.Jul 9 2024, 7:48 PM

This revision is now accepted and ready to land.Jul 9 2024, 7:48 PM

Avoid calling sofree() when pr_attach failed.

This revision now requires review to proceed.Aug 2 2024, 1:58 PM

Harbormaster completed remote builds in B58920: Diff 141740.Aug 2 2024, 1:58 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_socket.c

3 lines

sys/

socketvar.h

6 lines

Diff 141740

View Options

sys/kern/uipc_socket.c