Page MenuHomeFreeBSD
Differential D45917

kdb_sysctl_trap: suppress gcc -Warray-bounds
ClosedPublic
Actions

Authored by rlibby on Jul 8 2024, 3:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 9, 11:06 PM
Unknown Object (File)
Sat, Feb 7, 11:18 PM
Unknown Object (File)
Sat, Feb 7, 7:32 PM
Unknown Object (File)
Fri, Feb 6, 8:02 AM
Unknown Object (File)
Thu, Feb 5, 12:15 PM
Unknown Object (File)
Mon, Feb 2, 4:40 PM
Unknown Object (File)
Sun, Feb 1, 9:02 AM
Unknown Object (File)
Sat, Jan 31, 4:05 AM
View All Files
Subscribers
imp
olce

Details

Reviewers
kib
Commits
rGff1c63671b73: kdb_sysctl_trap: suppress gcc -Warray-bounds
Summary

gcc diagnosed a dereference of 0x10 with -Warray-bounds, which is
entirely sensible, except that this is a deliberate trap. Throw gcc off
with a volatile pointer.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby created this revision.Jul 8 2024, 3:58 PM
Herald added subscribers: olce, imp. · View Herald TranscriptJul 8 2024, 3:58 PM
rlibby requested review of this revision.Jul 8 2024, 3:58 PM
Harbormaster completed remote builds in B58566: Diff 140692.Jul 8 2024, 3:58 PM
rlibby added a parent revision: D45916: kern_exec.c: quiet gcc -Wmaybe-uninitialized.Jul 8 2024, 3:58 PM
rlibby added a child revision: D45918: ddb: make db_error reliably no-return.
kib accepted this revision.Jul 8 2024, 6:47 PM
kib added inline comments.
sys/kern/subr_kdb.c
241

I believe this is more style-ish

This revision is now accepted and ready to land.Jul 8 2024, 6:47 PM
rlibby added inline comments.Jul 8 2024, 7:56 PM
sys/kern/subr_kdb.c
241

We seem to have a mix of both for both *volatile and *const. I'll take your suggestion.

rlibby updated this revision to Diff 140705.Jul 8 2024, 8:34 PM

kib: style fixup

This revision now requires review to proceed.Jul 8 2024, 8:34 PM
Harbormaster completed remote builds in B58575: Diff 140705.Jul 8 2024, 8:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2024, 6:46 PM
Closed by commit rGff1c63671b73: kdb_sysctl_trap: suppress gcc -Warray-bounds (authored by rlibby). · Explain Why
This revision was automatically updated to reflect the committed changes.
rlibby added a commit: rGff1c63671b73: kdb_sysctl_trap: suppress gcc -Warray-bounds.

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 140736

View Options

sys/kern/subr_kdb.c

Loading...