Page MenuHomeFreeBSD

kdb_sysctl_trap: suppress gcc -Warray-bounds
ClosedPublic

Authored by rlibby on Jul 8 2024, 3:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 5:47 PM
Unknown Object (File)
Wed, Oct 1, 5:24 AM
Unknown Object (File)
Tue, Sep 30, 8:37 AM
Unknown Object (File)
Sep 7 2025, 4:43 PM
Unknown Object (File)
Sep 7 2025, 1:08 PM
Unknown Object (File)
Sep 6 2025, 1:34 AM
Unknown Object (File)
Sep 5 2025, 10:34 AM
Unknown Object (File)
Sep 4 2025, 7:36 PM
Subscribers

Details

Summary

gcc diagnosed a dereference of 0x10 with -Warray-bounds, which is
entirely sensible, except that this is a deliberate trap. Throw gcc off
with a volatile pointer.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby requested review of this revision.Jul 8 2024, 3:58 PM
kib added inline comments.
sys/kern/subr_kdb.c
241

I believe this is more style-ish

This revision is now accepted and ready to land.Jul 8 2024, 6:47 PM
sys/kern/subr_kdb.c
241

We seem to have a mix of both for both *volatile and *const. I'll take your suggestion.

This revision now requires review to proceed.Jul 8 2024, 8:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2024, 6:46 PM
This revision was automatically updated to reflect the committed changes.