Differential D45882

Revert "loader/lua: Remove compat shim for loader.lua_path"
ClosedPublic
Actions

Authored by imp on Jul 5 2024, 6:23 PM.

Tags

None

Referenced Files

	F126370273: D45882.id140585.diff
	Mon, Aug 18, 1:58 PM

	Unknown Object (File)
	Thu, Aug 14, 11:17 PM

	Unknown Object (File)
	Thu, Aug 14, 10:18 PM

	Unknown Object (File)
	Jul 6 2025, 11:25 PM

	Unknown Object (File)
	Jun 30 2025, 6:54 AM

	Unknown Object (File)
	Jun 30 2025, 4:35 AM

	Unknown Object (File)
	Jun 22 2025, 9:32 PM

	Unknown Object (File)
	Jun 21 2025, 1:12 AM

View All 92 Files

Subscribers

andrew_tao173.riddles.org.uk

Details

Reviewers

kevans
manu

Commits

rG598b9677b3e9: Revert "loader/lua: Remove compat shim for loader.lua_path"
rG522a65a8d97a: Revert "loader/lua: Remove compat shim for loader.lua_path"

Summary

This reverts commit ab97d42addae97a389c6f22d6bba62ed954bb8e7.

There's too many people in the field with FreeBSD 12.0 loader.efi that
stubbed their toe on upgrading to 14.1 since they'd not updated
loader.efi. While we sort out that mess, add back this workaround and
also whine the loader is too old. Can revisit after 14.2 maybe.

MFC After: 3 days
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58524
Build 55412: arc lint + arc unit

Event Timeline

imp created this revision.Jul 5 2024, 6:23 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 5 2024, 6:23 PM

Herald added subscribers: dab, andrew_tao173.riddles.org.uk. · View Herald Transcript

imp requested review of this revision.Jul 5 2024, 6:23 PM

imp added a parent revision: D45881: Revert "loader/lua: Remove pager shim".

Harbormaster completed remote builds in B58516: Diff 140585.Jul 5 2024, 6:23 PM

imp added a child revision: D45883: Revert "loader/lua: Remove workaround for command_error".Jul 5 2024, 6:23 PM

Just revert, kill the other changes.
Commit message locally updated to remove bit about whining, that will be a separate,
future commit.

Harbormaster completed remote builds in B58524: Diff 140597.Jul 5 2024, 8:47 PM

kevans accepted this revision.Jul 9 2024, 8:40 PM

This revision is now accepted and ready to land.Jul 9 2024, 8:40 PM

Closed by commit rG522a65a8d97a: Revert "loader/lua: Remove compat shim for loader.lua_path" (authored by imp). · Explain WhyJul 29 2024, 10:58 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG522a65a8d97a: Revert "loader/lua: Remove compat shim for loader.lua_path".

imp added a commit: rG598b9677b3e9: Revert "loader/lua: Remove compat shim for loader.lua_path".Aug 1 2024, 2:52 PM

Revision Contents
Changeset List

Path

Size

stand/

lua/

8 lines

Diff 140597

stand/lua/core.lua

Loading...