libthr: avoid gcc -Wcast-function-type
ClosedPublic
Actions

Authored by rlibby on Jul 1 2024, 4:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 5, 8:26 AM

	Unknown Object (File)
	Wed, Aug 5, 3:09 AM

	Unknown Object (File)
	Mon, Jul 27, 4:48 PM

	Unknown Object (File)
	Sat, Jul 25, 10:01 PM

	Unknown Object (File)
	Fri, Jul 24, 8:37 PM

	Unknown Object (File)
	Jul 19 2026, 5:42 PM

	Unknown Object (File)
	Jul 18 2026, 1:57 AM

	Unknown Object (File)
	Jul 5 2026, 3:51 AM

View All Files

Subscribers

imp

Details

Reviewers

jhb
kib

Commits

rG07d359787f0d: libthr: avoid gcc -Wcast-function-type

Summary

The actual types of pthread_func_t and interpos_func_t are not used.
Declare them as the generic void (*)(void) which suppresses warnings.

https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wcast-function-type

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Jul 1 2024, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 1 2024, 4:49 PM

rlibby requested review of this revision.Jul 1 2024, 4:49 PM

Harbormaster completed remote builds in B58445: Diff 140439.Jul 1 2024, 4:49 PM

rlibby added a parent revision: D45829: libthr _get_curthread i386: quiet gcc -Warray-bounds.Jul 1 2024, 4:49 PM

kib accepted this revision.Jul 1 2024, 9:11 PM

This revision is now accepted and ready to land.Jul 1 2024, 9:11 PM

Closed by commit rG07d359787f0d: libthr: avoid gcc -Wcast-function-type (authored by rlibby). · Explain WhyJul 3 2024, 4:15 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG07d359787f0d: libthr: avoid gcc -Wcast-function-type.

Revision Contents
Changeset List

Path

Size

lib/

libc/

include/

libc_private.h

4 lines

Diff 140518

View Options

lib/libc/include/libc_private.h

libthr: avoid gcc -Wcast-function-typeClosedPublicActions