Differential D45830

libthr: avoid gcc -Wcast-function-type
ClosedPublic
Actions

Authored by rlibby on Mon, Jul 1, 4:49 PM.

Tags

None

Referenced Files

	F87605633: D45830.diff
	Fri, Jul 5, 6:16 PM

	Unknown Object (File)
	Thu, Jul 4, 10:45 PM

	Unknown Object (File)
	Wed, Jul 3, 5:32 PM

	Unknown Object (File)
	Tue, Jul 2, 6:05 PM

	Unknown Object (File)
	Tue, Jul 2, 4:15 PM

	Unknown Object (File)
	Tue, Jul 2, 2:36 PM

	Unknown Object (File)
	Tue, Jul 2, 11:21 AM

Subscribers

Details

Reviewers

jhb
kib

Commits

rG07d359787f0d: libthr: avoid gcc -Wcast-function-type

Summary

The actual types of pthread_func_t and interpos_func_t are not used.
Declare them as the generic void (*)(void) which suppresses warnings.

https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wcast-function-type

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Mon, Jul 1, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 1, 4:49 PM

rlibby requested review of this revision.Mon, Jul 1, 4:49 PM

Harbormaster completed remote builds in B58445: Diff 140439.Mon, Jul 1, 4:49 PM

rlibby added a parent revision: D45829: libthr _get_curthread i386: quiet gcc -Warray-bounds.Mon, Jul 1, 4:49 PM

kib accepted this revision.Mon, Jul 1, 9:11 PM

This revision is now accepted and ready to land.Mon, Jul 1, 9:11 PM

Closed by commit rG07d359787f0d: libthr: avoid gcc -Wcast-function-type (authored by rlibby). · Explain WhyWed, Jul 3, 4:15 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG07d359787f0d: libthr: avoid gcc -Wcast-function-type.

Revision Contents
Changeset List

Path

Size

lib/

libc/

include/

4 lines

Diff 140518

lib/libc/include/libc_private.h

Loading...