libthr: avoid gcc -Wcast-function-type
ClosedPublic
Actions

Authored by rlibby on Jul 1 2024, 4:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 11, 4:31 AM

	Unknown Object (File)
	Sat, Oct 11, 4:31 AM

	Unknown Object (File)
	Sat, Oct 11, 4:31 AM

	Unknown Object (File)
	Fri, Oct 10, 9:27 PM

	Unknown Object (File)
	Thu, Oct 9, 12:50 AM

	Unknown Object (File)
	Thu, Oct 2, 4:36 AM

	Unknown Object (File)
	Tue, Sep 30, 8:08 AM

	Unknown Object (File)
	Aug 15 2025, 12:09 AM

View All 88 Files

Subscribers

imp

Details

Reviewers

jhb
kib

Commits

rG07d359787f0d: libthr: avoid gcc -Wcast-function-type

Summary

The actual types of pthread_func_t and interpos_func_t are not used.
Declare them as the generic void (*)(void) which suppresses warnings.

https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wcast-function-type

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Jul 1 2024, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 1 2024, 4:49 PM

rlibby requested review of this revision.Jul 1 2024, 4:49 PM

Harbormaster completed remote builds in B58445: Diff 140439.Jul 1 2024, 4:49 PM

rlibby added a parent revision: D45829: libthr _get_curthread i386: quiet gcc -Warray-bounds.Jul 1 2024, 4:49 PM

kib accepted this revision.Jul 1 2024, 9:11 PM

This revision is now accepted and ready to land.Jul 1 2024, 9:11 PM

Closed by commit rG07d359787f0d: libthr: avoid gcc -Wcast-function-type (authored by rlibby). · Explain WhyJul 3 2024, 4:15 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG07d359787f0d: libthr: avoid gcc -Wcast-function-type.

Revision Contents
Changeset List

Path

Size

lib/

libc/

include/

libc_private.h

4 lines

Diff 140518

View Options

lib/libc/include/libc_private.h

libthr: avoid gcc -Wcast-function-typeClosedPublicActions