libthr _get_curthread amd64: quiet gcc -Warray-bounds
ClosedPublic
Actions

Authored by rlibby on Mon, Jul 1, 4:49 PM.

Details

Reviewers

jhb
kib

Commits

rG657b1276ad4c: libthr _get_curthread amd64: quiet gcc -Warray-bounds

Summary

Use a constant input operand instead of a bogus memory reference to tell
the compiler about offsetof(struct tcb, tcb_thread) in the fs segment.
Otherwise gcc complains if we tell it we are reading memory offset 0x10.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Mon, Jul 1, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 1, 4:49 PM

rlibby requested review of this revision.Mon, Jul 1, 4:49 PM

Harbormaster completed remote builds in B58443: Diff 140437.Mon, Jul 1, 4:49 PM

rlibby added a parent revision: D45827: amd64 pcpu: fix clobbers, suppress warnings, and clean up.Mon, Jul 1, 4:49 PM

rlibby added a child revision: D45829: libthr _get_curthread i386: quiet gcc -Warray-bounds.

kib accepted this revision.Mon, Jul 1, 9:10 PM

This revision is now accepted and ready to land.Mon, Jul 1, 9:10 PM

Closed by commit rG657b1276ad4c: libthr _get_curthread amd64: quiet gcc -Warray-bounds (authored by rlibby). · Explain WhyWed, Jul 3, 4:15 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG657b1276ad4c: libthr _get_curthread amd64: quiet gcc -Warray-bounds.

Revision Contents
Changeset List

Path

Size

lib/

libthr/

arch/

amd64/

include/

pthread_md.h

4 lines

Diff 140516

View Options

lib/libthr/arch/amd64/include/pthread_md.h

libthr _get_curthread amd64: quiet gcc -Warray-boundsClosedPublicActions