ext4_ext_tree_init: correct memset initialization
ClosedPublic
Actions

Authored by rlibby on Sun, Jun 23, 3:59 PM.

Details

Reviewers

markj
pfg
fsu

Commits

rGf29bdea04776: ext4_ext_tree_init: correct memset initialization

Summary

gcc -Wmemset-elt-size diagnosed this. The code was only initializing
1/4 of the array. However, it was actually harmless, as the only caller
had done an M_ZERO allocation anyway.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Sun, Jun 23, 3:59 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Jun 23, 3:59 PM

rlibby requested review of this revision.Sun, Jun 23, 3:59 PM

Harbormaster completed remote builds in B58311: Diff 140122.Sun, Jun 23, 3:59 PM

markj accepted this revision.Mon, Jun 24, 5:12 PM

This revision is now accepted and ready to land.Mon, Jun 24, 5:12 PM

Closed by commit rGf29bdea04776: ext4_ext_tree_init: correct memset initialization (authored by rlibby). · Explain WhyTue, Jun 25, 5:43 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rGf29bdea04776: ext4_ext_tree_init: correct memset initialization.

Revision Contents
Changeset List

Path

Size

sys/

fs/

ext2fs/

ext2_extents.c

2 lines

Diff 140233

View Options

sys/fs/ext2fs/ext2_extents.c

ext4_ext_tree_init: correct memset initializationClosedPublicActions