virstor: remove relation between chunk size and MAXPHYS

[rlibby]

Summary

There's no reason why the virstor chunk size needs to relate to MAXPHYS.
Remove it. Instead, just make sure that the chunk size is a multiple of
the sector size.

Sponsored by: Dell EMC Isilon

Test Plan

New test in D45535

% sudo kyua debug -k /usr/tests/sys/Kyuafile geom/class/virstor/virstor_test:basic
Executing command [ gvirstor label -v -s 64M -m 512 virstor.bjyhzA /dev/md0 ]
Executing command [ gvirstor destroy virstor.bjyhzA ]

Destroying test virstor device: virstor.bjyhzA
Removing test memory disk: md0
geom/class/virstor/virstor_test:basic -> passed

[markj]

I don't know this GEOM well enough to say whether this is right, but I can't see any reason it's wrong. It's unfortunate that there are no regression tests for this code.

lib/geom/virstor/geom_virstor.c

235

[rlibby]

In D45518#1038621, @markj wrote:

I don't know this GEOM well enough to say whether this is right, but I can't see any reason it's wrong. It's unfortunate that there are no regression tests for this code.

I see there are tests for other geoms in tests/sys/geom, but I haven't figured out how to run them yet. Do you know? I might be able to cobble together something basic at least.

[rlibby]

In D45518#1038712, @rlibby wrote:

In D45518#1038621, @markj wrote:

I don't know this GEOM well enough to say whether this is right, but I can't see any reason it's wrong. It's unfortunate that there are no regression tests for this code.

I see there are tests for other geoms in tests/sys/geom, but I haven't figured out how to run them yet. Do you know? I might be able to cobble together something basic at least.

Ah, I got it with

sudo kyua test -k /usr/tests/sys/geom/Kyuafile

They are not hooked up to the sys/Kyuafile. I wonder why.

[markj]

In D45518#1038713, @rlibby wrote:

In D45518#1038712, @rlibby wrote:

In D45518#1038621, @markj wrote:

I don't know this GEOM well enough to say whether this is right, but I can't see any reason it's wrong. It's unfortunate that there are no regression tests for this code.

I see there are tests for other geoms in tests/sys/geom, but I haven't figured out how to run them yet. Do you know? I might be able to cobble together something basic at least.

Ah, I got it with

sudo kyua test -k /usr/tests/sys/geom/Kyuafile

They are not hooked up to the sys/Kyuafile. I wonder why.

Hmm, they are on my system. When I run the full regression test suite I know for sure that the GEOM regression tests run. (The GELI ones in particular generate a ton of console output, so it's easy to see.)

[rlibby]

In D45518#1038713, @rlibby wrote:

They are not hooked up to the sys/Kyuafile. I wonder why.

Sorry for the spam. They are hooked up, I just don't know kyua very well.

[rlibby]

markj feedback: fix style while here