goem: Add counts for enomem and pausing
ClosedPublic
Actions

Authored by imp on May 22 2024, 11:08 PM.

Details

Reviewers

phk
markj
kib
jhb

Commits

rG32f40fc9837d: geom: Add counts for enomem and pausing

Summary

Add counts for the number of requests that complete with the ENOMEM as
kern.geom.nomem_count and the number of times we pause to let the system
recover kern.geom.pause_count.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.May 22 2024, 11:08 PM

imp created this revision.

Harbormaster completed remote builds in B57856: Diff 138950.May 22 2024, 11:08 PM

imp added a child revision: D45310: cam: Drop periph lock when completing I/O with ENOMEM status.May 22 2024, 11:08 PM

imp added reviewers: phk, markj, kib, jhb.May 22 2024, 11:10 PM

kib added inline comments.May 22 2024, 11:53 PM

sys/geom/geom_io.c
78	u_long?
836	The min() is useless, zero count is converted to 1 tick by pause_sbt()
837	Why is this increment non-atomic?

imp added inline comments.May 23 2024, 3:15 AM

sys/geom/geom_io.c
78	This, or maybe counter_u64_t?
836	I'll do a followup commit.
837	g_down is one thread, no? I could use counters here if I'm wrong about that.

kib added inline comments.May 23 2024, 3:29 AM

sys/geom/geom_io.c
78	These events are exceptional. Counter64 adds non-insignificant memory overhead and fetch complications there, without benefits IMO.
837	ok, the perhaps add a single-line hint about this, please