Page MenuHomeFreeBSD

Work around a race condition on interface move between vnets.
ClosedPublic

Authored by bz on Dec 12 2015, 12:28 PM.
Tags
None
Referenced Files
F105784560: D4529.diff
Fri, Dec 20, 4:03 PM
Unknown Object (File)
Thu, Dec 5, 4:10 PM
Unknown Object (File)
Fri, Nov 22, 9:34 AM
Unknown Object (File)
Oct 20 2024, 5:12 AM
Unknown Object (File)
Sep 24 2024, 4:00 AM
Unknown Object (File)
Sep 18 2024, 11:04 PM
Unknown Object (File)
Sep 8 2024, 11:59 AM
Unknown Object (File)
Sep 5 2024, 6:52 PM
Subscribers

Details

Summary

If vnets are torn down while ifconfig runs an ioctl to say,
destroy an epair(4), we may hit if_detach_internal() without
holding a lock and by the time we aquire it the interface might
be gone. We should not panic() in this case as it is our fault
for not holding the lock all the way. It is not ideal to
return silently without error to user space, but other callers
will all ignore the return values so do not change the entire
KPI for little benefit for now. The ifp will be dealt with one
way or another still.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz retitled this revision from to Work around a race condition on interface move between vnets..
bz updated this object.
bz edited the test plan for this revision. (Show Details)
bz added reviewers: gnn, emaste, rwatson.
gnn edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2015, 3:37 PM
This revision was automatically updated to reflect the committed changes.