Page MenuHomeFreeBSD
Differential D45240

access(2): Discourage use of these system calls.
ClosedPublic
Actions

Authored by des on May 18 2024, 9:34 AM.
Tags
None
Referenced Files
F103919885: D45240.id138836.diff
Sun, Dec 1, 5:43 AM
Unknown Object (File)
Mon, Nov 25, 10:10 PM
Unknown Object (File)
Sun, Nov 24, 8:30 AM
Unknown Object (File)
Sat, Nov 23, 8:06 AM
Unknown Object (File)
Fri, Nov 22, 5:53 PM
Unknown Object (File)
Wed, Nov 20, 8:12 AM
Unknown Object (File)
Mon, Nov 18, 5:33 PM
Unknown Object (File)
Mon, Nov 18, 5:22 PM
View All 71 Files
Subscribers
emaste
imp

Details

Reviewers
gbe
emaste
Group Reviewers
manpages
Commits
rGfb18c369c32d: access(2): Discourage use of these system calls.
rG55cd52a4418d: access(2): Discourage use of these system calls.
rG79b39f23e134: access(2): Discourage use of these system calls.
rGa4be1eb21165: access(2): Discourage use of these system calls.
Summary

Fixes: 421025a274fb
PR: 262895
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57750
Build 54638: arc lint + arc unit

Event Timeline

des created this revision.May 18 2024, 9:34 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 18 2024, 9:34 AM
des requested review of this revision.May 18 2024, 9:34 AM
Harbormaster completed remote builds in B57750: Diff 138711.May 18 2024, 9:35 AM
des updated this revision to Diff 138836.May 21 2024, 10:15 AM

reword

Harbormaster completed remote builds in B57814: Diff 138836.May 21 2024, 10:15 AM
emaste accepted this revision.EditedMay 21 2024, 5:52 PM
emaste added a subscriber: emaste.

I think this is fine. Your comment in the PR that these answer the question what would happen if I tried to open() this path helps avoid any confusion that might exist. But I can't think of wording that is succinct, accurate, and covers all cases so don't have a suggestion to make.

This revision is now accepted and ready to land.May 21 2024, 5:52 PM
imp added a comment.May 21 2024, 6:35 PM

"Access and friends provide a good first guess if a future open might succeed." Might be good to insert at the start. Or "access, eaccess and faccessat provide..." and change the list at the start of the next sentence to "These system calls".

des retitled this revision from libsys: Remove misleading verbiage from access(2) to access(2): Discourage use of these system calls..May 21 2024, 9:12 PM
des updated this revision to Diff 138862.May 21 2024, 9:13 PM

be more explicit

This revision now requires review to proceed.May 21 2024, 9:13 PM
Harbormaster completed remote builds in B57823: Diff 138862.May 21 2024, 9:13 PM
emaste accepted this revision.May 21 2024, 9:16 PM

LGTM. "whether an attempt to access the file" is definitely an improvement

This revision is now accepted and ready to land.May 21 2024, 9:16 PM
Closed by commit rGa4be1eb21165: access(2): Discourage use of these system calls. (authored by des). · Explain WhyMay 21 2024, 10:36 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGa4be1eb21165: access(2): Discourage use of these system calls..
des added a commit: rG79b39f23e134: access(2): Discourage use of these system calls..May 23 2024, 2:42 AM
des added a commit: rG55cd52a4418d: access(2): Discourage use of these system calls..May 23 2024, 2:44 AM
des added a commit: rGfb18c369c32d: access(2): Discourage use of these system calls..May 23 2024, 2:48 AM

Revision Contents
Changeset List

PathSize
lib/
libsys/
20 lines

Diff 138711

View Options

lib/libsys/access.2

Loading...