Page MenuHomeFreeBSD

access(2): Discourage use of these system calls.
ClosedPublic

Authored by des on May 18 2024, 9:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 4:53 AM
Unknown Object (File)
Sun, Nov 10, 4:47 PM
Unknown Object (File)
Thu, Oct 17, 6:23 PM
Unknown Object (File)
Wed, Oct 16, 4:48 AM
Unknown Object (File)
Oct 15 2024, 5:46 PM
Unknown Object (File)
Oct 15 2024, 3:44 PM
Unknown Object (File)
Oct 14 2024, 4:39 PM
Unknown Object (File)
Oct 14 2024, 10:28 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.May 18 2024, 9:34 AM
emaste added a subscriber: emaste.

I think this is fine. Your comment in the PR that these answer the question what would happen if I tried to open() this path helps avoid any confusion that might exist. But I can't think of wording that is succinct, accurate, and covers all cases so don't have a suggestion to make.

This revision is now accepted and ready to land.May 21 2024, 5:52 PM

"Access and friends provide a good first guess if a future open might succeed." Might be good to insert at the start. Or "access, eaccess and faccessat provide..." and change the list at the start of the next sentence to "These system calls".

des retitled this revision from libsys: Remove misleading verbiage from access(2) to access(2): Discourage use of these system calls..May 21 2024, 9:12 PM
This revision now requires review to proceed.May 21 2024, 9:13 PM

LGTM. "whether an attempt to access the file" is definitely an improvement

This revision is now accepted and ready to land.May 21 2024, 9:16 PM