Page MenuHomeFreeBSD

Implement atomic_load_acq_16
ClosedPublic

Authored by br on May 17 2024, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 7, 2:57 AM
Unknown Object (File)
Tue, Aug 27, 2:17 AM
Unknown Object (File)
Aug 6 2024, 10:42 PM
Unknown Object (File)
Jul 3 2024, 11:51 AM
Unknown Object (File)
Jun 27 2024, 5:56 PM
Unknown Object (File)
Jun 21 2024, 8:06 PM
Unknown Object (File)
Jun 21 2024, 4:30 PM
Unknown Object (File)
Jun 9 2024, 8:02 PM
Subscribers

Details

Summary
  • Implement atomic_load_acq_16(), atomic_store_rel_16(). One of these needed for bhyve pci emulation.
  • Group 16-bit functions similarly to 32 and 64.
Test Plan

bhyve pass

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br requested review of this revision.May 17 2024, 10:03 AM
br created this revision.
sys/riscv/include/atomic.h
116–144

These two lines should be grouped with the other #defines below.

122

?

sys/riscv/include/atomic.h
116–144

should we use same grouping as for 32 / 64 ? cmpset/fcmpset seem to go before acquire/release declarations in 32, 64 variants

122

needed by sys/_atomic_subword.h as it checks if macro defined

mhorne added inline comments.
sys/riscv/include/atomic.h
116–144

You are right, it is fine as-is.

This revision is now accepted and ready to land.May 22 2024, 1:51 PM
This revision was automatically updated to reflect the committed changes.