Page MenuHomeFreeBSD

Implement atomic_load_acq_16
ClosedPublic

Authored by br on May 17 2024, 10:03 AM.
Tags
None
Referenced Files
F86537207: D45228.diff
Fri, Jun 21, 8:06 PM
F86527319: D45228.diff
Fri, Jun 21, 4:30 PM
Unknown Object (File)
Sun, Jun 9, 8:02 PM
Unknown Object (File)
Sat, May 25, 2:00 PM
Unknown Object (File)
Sat, May 25, 1:59 PM
Unknown Object (File)
Sat, May 25, 8:31 AM
Unknown Object (File)
May 22 2024, 5:38 PM
Unknown Object (File)
May 20 2024, 5:33 PM
Subscribers

Details

Summary
  • Implement atomic_load_acq_16(), atomic_store_rel_16(). One of these needed for bhyve pci emulation.
  • Group 16-bit functions similarly to 32 and 64.
Test Plan

bhyve pass

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.May 17 2024, 10:03 AM
br created this revision.
sys/riscv/include/atomic.h
116–117

These two lines should be grouped with the other #defines below.

122

?

sys/riscv/include/atomic.h
116–117

should we use same grouping as for 32 / 64 ? cmpset/fcmpset seem to go before acquire/release declarations in 32, 64 variants

122

needed by sys/_atomic_subword.h as it checks if macro defined

mhorne added inline comments.
sys/riscv/include/atomic.h
116–117

You are right, it is fine as-is.

This revision is now accepted and ready to land.May 22 2024, 1:51 PM
This revision was automatically updated to reflect the committed changes.