linuxkpi: spinlock: Simplify code
ClosedPublic
Actions

The main reason for this change is that now struct mtx and spinlock_t are 100% interchangeable in code which is a first step to share structures between linuxkpi driver and native ones.

manu edited the summary of this revision. (Show Details)Wed, May 15, 1:09 PM

I believe this will be ABI-compatible so there should be no trouble upgrading across the commit

This revision is now accepted and ready to land.Wed, May 15, 1:09 PM

bz accepted this revision.Wed, May 15, 5:18 PM

In D45205#1031216, @manu wrote:

The main reason for this change is that now struct mtx and spinlock_t are 100% interchangeable in code which is a first step to share structures between linuxkpi driver and native ones.

Can you elaborate on this a bit? Do you have an example? Oh, not the struct mtx you mean but structures embedding struct mtx?

In D45205#1031322, @bz wrote:

In D45205#1031216, @manu wrote:

The main reason for this change is that now struct mtx and spinlock_t are 100% interchangeable in code which is a first step to share structures between linuxkpi driver and native ones.

Can you elaborate on this a bit? Do you have an example? Oh, not the struct mtx you mean but structures embedding struct mtx?

Yes, I'm working on dma-buf and I want most of the code to be usable for native driver and that structures are shareable with linuxkpi drivers too so the base structure needs to be the same, the fact that I can now spin_lock(blah) if blah is struct mtx or spinlock_t helps.

Closed by commit rGae38a1a1bfdf: linuxkpi: spinlock: Simplify code (authored by manu). · Explain WhyThu, May 16, 7:41 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGae38a1a1bfdf: linuxkpi: spinlock: Simplify code.