Increase IOAPIC_MAX_ID to 255 (from 254)
ClosedPublic
Actions

Authored by emaste on Fri, May 10, 6:10 PM.

Details

Reviewers

jhb
royger
kib

Commits

rG147c7e4dde23: Increase IOAPIC_MAX_ID to 255 (from 254)
rG18119e711f1c: Increase IOAPIC_MAX_ID to 255 (from 254)
rG4e3286818327: Increase IOAPIC_MAX_ID to 255 (from 254)

Summary

A test system here panicked with "madt_parse_apics: I/O APIC ID 255 too high". I/O APIC ID 255 is permissible.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Fri, May 10, 6:10 PM

emaste created this revision.

kib accepted this revision.Fri, May 10, 6:16 PM

This revision is now accepted and ready to land.Fri, May 10, 6:16 PM

Might want a comment or a detail in the commit log that while the 0xff ID is used for broadcast IPIs for local APICs when not using x2APIC, IPIs aren't sent to I/O APICs, so it's ok for an I/O APIC to reuse that ID. Might also want to note that I/O APIC IDs haven't been meaningful since the 3-wire APIC bus which was last used by systems using Pentium CPUs.