Page MenuHomeFreeBSD
Differential D45148

atf: Guard against multiple evaluation.
ClosedPublic
Actions

Authored by des on May 10 2024, 6:12 AM.
Tags
None
Referenced Files
F86146237: D45148.diff
Sun, Jun 16, 3:04 AM
Unknown Object (File)
Thu, May 23, 8:10 PM
Unknown Object (File)
Sun, May 19, 8:38 PM
Unknown Object (File)
May 17 2024, 4:31 AM
Unknown Object (File)
May 15 2024, 10:12 AM
Unknown Object (File)
May 13 2024, 9:12 AM
Unknown Object (File)
May 13 2024, 6:56 AM
Unknown Object (File)
May 12 2024, 9:17 PM
Subscribers
imp
lwhsu
ngie

Details

Reviewers
kevans
ngie
Group Reviewers
tests
Commits
rG0829f9334cdd: atf: Guard against multiple evaluation.
rGd16bc4fda821: atf: Guard against multiple evaluation.
rG745ee870031e: atf: Guard against multiple evaluation.
rGa7beca6fb113: atf: Guard against multiple evaluation.
Summary

Note that the ATF-C++ macros have the same issue, but they are not as
easily fixed.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57651
Build 54539: arc lint + arc unit

Event Timeline

des created this revision.May 10 2024, 6:12 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 10 2024, 6:12 AM
des requested review of this revision.May 10 2024, 6:12 AM
Harbormaster completed remote builds in B57651: Diff 138333.May 10 2024, 6:12 AM
lwhsu added a subscriber: lwhsu.May 10 2024, 6:33 AM

BTW, ATF is under FreeBSD org at GitHub: https://github.com/freebsd/atf , we an fix there and import to base.

des added a comment.May 10 2024, 8:52 AM

Cool, feel free to open an issue there, I don't want to have to wait weeks or months for a fix.

ngie accepted this revision.May 14 2024, 10:33 PM
ngie added a subscriber: ngie.
ngie added inline comments.
contrib/atf/atf-c/macros.h
174

_(picking a line)_
Should this macro expansion use #_atf_expected, #_atf_actual instead of #expected, #actual? It shouldn't matter, except with non standards conforming C/C++ toolchains.

This revision is now accepted and ready to land.May 14 2024, 10:33 PM
des marked an inline comment as done.May 15 2024, 10:07 AM
des added inline comments.
contrib/atf/atf-c/macros.h
174

No, that wouldn't work since _atf_expected and _atf_actual aren't macro parameters, and I don't see why you'd want to.

Closed by commit rGa7beca6fb113: atf: Guard against multiple evaluation. (authored by des). · Explain WhyMay 15 2024, 10:09 AM
This revision was automatically updated to reflect the committed changes.
des marked an inline comment as done.
des added a commit: rGa7beca6fb113: atf: Guard against multiple evaluation..
des added a commit: rG745ee870031e: atf: Guard against multiple evaluation..Mon, May 20, 9:09 AM
des added a commit: rGd16bc4fda821: atf: Guard against multiple evaluation..Mon, May 20, 9:35 AM
des added a commit: rG0829f9334cdd: atf: Guard against multiple evaluation..Mon, May 20, 8:38 PM

Revision Contents
Changeset List

PathSize
contrib/
atf/
atf-c/
151 lines

Diff 138333

View Options

contrib/atf/atf-c/macros.h

Loading...