Page MenuHomeFreeBSD

libc/tests: Fix installation without MK_TOOLCHAIN
ClosedPublic

Authored by markj on May 1 2024, 1:44 AM.
Tags
None
Referenced Files
F131873086: D45035.id139171.diff
Sat, Oct 11, 9:07 PM
F131873085: D45035.id.diff
Sat, Oct 11, 9:07 PM
F131873082: D45035.id137921.diff
Sat, Oct 11, 9:07 PM
F131825702: D45035.diff
Sat, Oct 11, 12:01 PM
Unknown Object (File)
Tue, Sep 23, 7:06 AM
Unknown Object (File)
Thu, Sep 18, 1:50 AM
Unknown Object (File)
Sep 12 2025, 5:02 AM
Unknown Object (File)
Sep 9 2025, 10:13 AM
Subscribers

Details

Summary

There is some strange conditional logic here to avoid building a
particular test if a certain UBSAN library isn't present. This causes
build failures for me when doing an "installworld WITHOUT_TOOLCHAIN=",
which I do frequently during tests. (This failure appeared for me only
very recently, I'm not quite sure why.)

I presume the problem is that SYSROOT is unset during installworld, so
the build sees the host's copy of libclang_rt.ubsan_standalone.a and
then tries to install a binary that wasn't built during buildworld.
Assuming that this is correct, try to make the check a bit less fragile.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable