Page MenuHomeFreeBSD

libc/tests: Fix installation without MK_TOOLCHAIN
ClosedPublic

Authored by markj on May 1 2024, 1:44 AM.
Tags
None
Referenced Files
F154291979: D45035.id139171.diff
Mon, Apr 27, 3:52 PM
F154245445: D45035.id.diff
Mon, Apr 27, 9:19 AM
Unknown Object (File)
Sun, Apr 19, 6:03 PM
Unknown Object (File)
Tue, Apr 7, 1:55 AM
Unknown Object (File)
Sun, Apr 5, 3:08 PM
Unknown Object (File)
Fri, Apr 3, 11:40 PM
Unknown Object (File)
Thu, Apr 2, 3:16 AM
Unknown Object (File)
Tue, Mar 31, 3:07 AM
Subscribers

Details

Summary

There is some strange conditional logic here to avoid building a
particular test if a certain UBSAN library isn't present. This causes
build failures for me when doing an "installworld WITHOUT_TOOLCHAIN=",
which I do frequently during tests. (This failure appeared for me only
very recently, I'm not quite sure why.)

I presume the problem is that SYSROOT is unset during installworld, so
the build sees the host's copy of libclang_rt.ubsan_standalone.a and
then tries to install a binary that wasn't built during buildworld.
Assuming that this is correct, try to make the check a bit less fragile.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable