Page MenuHomeFreeBSD

sound: Merge pcm_chn_destroy() and chn_kill()
ClosedPublic

Authored by christos on Sat, Apr 27, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 1:43 AM
Unknown Object (File)
Wed, May 1, 6:13 PM
Unknown Object (File)
Wed, May 1, 5:04 PM
Unknown Object (File)
Tue, Apr 30, 8:20 PM
Unknown Object (File)
Tue, Apr 30, 7:40 AM
Unknown Object (File)
Mon, Apr 29, 6:07 PM
Unknown Object (File)
Mon, Apr 29, 6:06 PM
Unknown Object (File)
Sun, Apr 28, 9:36 PM
Subscribers

Details

Summary

pcm_chn_destroy() acts like a wrapper around chn_kill(), and
additionally calls a few more functions that should in fact be part of
chn_kill()'s logic. Merge pcm_chn_destroy()'s functionality in
chn_kill() to improve readability, as well as code layering.

While here, convert chn_kill() to void as it currently always returns 0.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
sys/dev/sound/pcm/channel.c
1285–1288

There is something wonky going on with the indentation here.

This revision is now accepted and ready to land.Sat, Apr 27, 11:15 PM