Page MenuHomeFreeBSD
Differential D44868

elf_common.h: Add STO_AARCH64_VARIANT_PCS
ClosedPublic
Actions

Authored by andrew on Fri, Apr 19, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 11:21 AM
Unknown Object (File)
Fri, Apr 26, 3:16 AM
Unknown Object (File)
Thu, Apr 25, 11:47 PM
Unknown Object (File)
Thu, Apr 25, 1:50 PM
Unknown Object (File)
Thu, Apr 25, 1:50 PM
Unknown Object (File)
Thu, Apr 25, 7:14 AM
Unknown Object (File)
Sat, Apr 20, 5:07 PM
Unknown Object (File)
Sat, Apr 20, 3:14 PM
Subscribers
emaste
imp

Details

Reviewers
kib
imp
Group Reviewers
arm64
Commits
rGd7ac42676dc4: elf_common.h: Add STO_AARCH64_VARIANT_PCS
Summary

This is used to mark symbols that use a variant procedure call with
a different calling convention to the main ABI.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Fri, Apr 19, 3:36 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 19, 3:36 PM
andrew requested review of this revision.Fri, Apr 19, 3:36 PM
andrew added a child revision: D44869: rtld: Add support for arm64 variant pcs.
Harbormaster completed remote builds in B57219: Diff 137393.Fri, Apr 19, 3:37 PM
imp accepted this revision.Fri, Apr 19, 3:41 PM
This revision is now accepted and ready to land.Fri, Apr 19, 3:41 PM
emaste added a subscriber: emaste.Fri, Apr 19, 3:46 PM

Do we need to add support to e.g. ELF Tool Chain readelf and nm to decode these values?

kib added a comment.Fri, Apr 19, 5:40 PM

Is it flag or enumeration?

kib accepted this revision.Fri, Apr 19, 5:43 PM
andrew added a comment.Tue, Apr 23, 9:18 AM

A flag. https://github.com/ARM-software/abi-aa/blob/main/aaelf64/aaelf64.rst#st_other-values lists it under Processor specific st_other flags.

andrew added a comment.Tue, Apr 23, 9:24 AM
In D44868#1022920, @emaste wrote:

Do we need to add support to e.g. ELF Tool Chain readelf and nm to decode these values?

It looks like binutils adds [VARIANT_PCS] to symbols with this flag, e.g.

97: 0000000000000000 0 FUNC GLOBAL DEFAULT [VARIANT_PCS] UND variant_pcs_test

Closed by commit rGd7ac42676dc4: elf_common.h: Add STO_AARCH64_VARIANT_PCS (authored by andrew). · Explain WhyWed, Apr 24, 6:32 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGd7ac42676dc4: elf_common.h: Add STO_AARCH64_VARIANT_PCS.

Revision Contents
Changeset List

PathSize
sys/
sys/
3 lines

Diff 137610

View Options

sys/sys/elf_common.h

Loading...