NOTES: Move NVMe entries to MI file
ClosedPublic
Actions

Authored by jhb on Apr 8 2024, 8:31 PM.

Details

Reviewers

imp
andrew
manu

Commits

rG8f7105a20697: NOTES: Move NVMe entries to MI file

Summary

While here, adjust the sample setting for NVME_USE_NVD to use a
non-default setting as is typical in entries in NOTES.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 8 2024, 8:31 PM

Herald added a reviewer: andrew. · View Herald TranscriptApr 8 2024, 8:31 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, emaste. · View Herald Transcript

jhb requested review of this revision.Apr 8 2024, 8:31 PM

Harbormaster completed remote builds in B56973: Diff 136745.Apr 8 2024, 8:31 PM

jhb added a parent revision: D44690: sys: Enable NVMe drivers on all architectures.Apr 8 2024, 8:31 PM

Don't you need nodevice rntries for the 32bit powerpc?

Oh and armv7?

This passed a MAKE_JUST_KERNELS=yes tinderbox.

Do we have a good way of tracking where things work and have been tested? User expectations is what i worry about.... otherwise, i think it's good...

In D44691#1018890, @imp wrote:

Do we have a good way of tracking where things work and have been tested? User expectations is what i worry about.... otherwise, i think it's good...

I expect nvd/nda to works on armv7 but the number of boards with PCI-e is very low.
But this is NOTES only so having 32 bits "build test" for nvme is not that bad I think.

This revision is now accepted and ready to land.Apr 9 2024, 5:31 AM

Closed by commit rG8f7105a20697: NOTES: Move NVMe entries to MI file (authored by jhb). · Explain WhyApr 9 2024, 10:05 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8f7105a20697: NOTES: Move NVMe entries to MI file.