Page MenuHomeFreeBSD

lagg: remove use of net epoch in the ioctl paths
Needs ReviewPublic

Authored by glebius on Apr 3 2024, 5:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 5:44 PM
Unknown Object (File)
Wed, Aug 12, 4:31 PM
Unknown Object (File)
Mon, Aug 10, 7:15 AM
Unknown Object (File)
Mon, Aug 10, 6:03 AM
Unknown Object (File)
Sat, Aug 8, 4:46 PM
Unknown Object (File)
Sat, Aug 8, 9:38 AM
Unknown Object (File)
Sat, Aug 8, 5:51 AM
Unknown Object (File)
Sat, Aug 8, 2:00 AM
Subscribers

Details

Reviewers
None
Group Reviewers
network
Summary

Rely on LAGG_SLOCK() instead. The use of network epoch(9) here was added
in 6573d7580b851 (later tidied by 87bf9b9cbeebc) as a large sweep that
blindly substituted blocking kernel primitives with epoch(9). In these
particular code paths use of epoch(9) is incorrect and doesn't provide any
protection against a stale pointer. Recent fix 48698ead6ff0, which should
actually have removed the epoch use, created a potential sleeping in epoch
problem.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56887
Build 53775: arc lint + arc unit