Page MenuHomeFreeBSD

lagg: remove use of net epoch in the ioctl paths
Needs ReviewPublic

Authored by glebius on Apr 3 2024, 5:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 31, 3:56 AM
Unknown Object (File)
Fri, Mar 20, 7:28 AM
Unknown Object (File)
Thu, Mar 19, 6:58 PM
Unknown Object (File)
Fri, Mar 13, 7:16 AM
Unknown Object (File)
Thu, Mar 12, 7:21 PM
Unknown Object (File)
Sun, Mar 8, 5:17 AM
Unknown Object (File)
Feb 12 2026, 11:22 PM
Unknown Object (File)
Feb 8 2026, 8:17 AM
Subscribers

Details

Reviewers
None
Group Reviewers
network
Summary

Rely on LAGG_SLOCK() instead. The use of network epoch(9) here was added
in 6573d7580b851 (later tidied by 87bf9b9cbeebc) as a large sweep that
blindly substituted blocking kernel primitives with epoch(9). In these
particular code paths use of epoch(9) is incorrect and doesn't provide any
protection against a stale pointer. Recent fix 48698ead6ff0, which should
actually have removed the epoch use, created a potential sleeping in epoch
problem.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56887
Build 53775: arc lint + arc unit