lockdep_assert: wrong 'cond' used in WARN_ON MACRO
ClosedPublic
Actions

Authored by weike.chen_dell.com on Apr 3 2024, 3:27 AM.

Tags

None

Referenced Files

	F86815665: D44604.id136461.diff
	Wed, Jun 26, 12:27 AM

	Unknown Object (File)
	Sun, Jun 16, 10:13 AM

	Unknown Object (File)
	Fri, Jun 7, 3:30 AM

	Unknown Object (File)
	Apr 27 2024, 3:25 PM

	Unknown Object (File)
	Apr 26 2024, 4:41 AM

	Unknown Object (File)
	Apr 16 2024, 3:02 AM

	Unknown Object (File)
	Apr 12 2024, 10:18 AM

	Unknown Object (File)
	Apr 11 2024, 7:06 PM

Subscribers

Details

Reviewers

jeff
dchagin
wulf

Group Reviewers

linuxkpi
Linux Emulation

Commits

rG21f4cf5ccf87: LinuxKPI: lockdep_assert: wrong 'cond' used in WARN_ON MACRO

Summary

'cond' in WARN_ON need be bracketed, otherwise it is wrong for multiple conditions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

weike.chen_dell.com created this revision.Apr 3 2024, 3:27 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptApr 3 2024, 3:27 AM

weike.chen_dell.com requested review of this revision.Apr 3 2024, 3:27 AM

LGTM

This revision is now accepted and ready to land.Apr 10 2024, 12:48 AM

Closed by commit rG21f4cf5ccf87: LinuxKPI: lockdep_assert: wrong 'cond' used in WARN_ON MACRO (authored by weike.chen_dell.com, committed by wulf). · Explain WhyThu, Jun 6, 8:43 PM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG21f4cf5ccf87: LinuxKPI: lockdep_assert: wrong 'cond' used in WARN_ON MACRO.

You're a hero, mate. Thanks!

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

lockdep.h

4 lines

Diff 136461

View Options

sys/compat/linuxkpi/common/include/linux/lockdep.h

lockdep_assert: wrong 'cond' used in WARN_ON MACROClosedPublicActions