More restrict on probe function entry. We only check first instruction now. The only expcetion case is when function uses va_args, the first instrction is skipped.
ClosedPublic
Actions

Authored by howard0su_gmail.com on Dec 7 2015, 7:00 AM.

Details

Reviewers

andrew
mmel
rwatson

Group Reviewers

Contributor Reviewers (ports)

Commits

rS292663: Be stricter on which functions we can probe with FBT. We now only check the

Summary

with this change, fbt detected 12 less functions. Most are hand write
assembly functions, and some are c functions without stack usage.
< bcopy
< bzero
< copyin
< copyout
< get_pc_str_offset
< insw16
< inswm8
< memcpy
< outsw16
< outswm8
< read_multi_1
< write_multi_1

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

howard0su_gmail.com updated this revision to Diff 10841.Dec 7 2015, 7:00 AM

howard0su_gmail.com retitled this revision from to More restrict on probe function entry. We only check first instruction now. The only expcetion case is when function uses va_args, the first instrction is skipped..

howard0su_gmail.com updated this object.

howard0su_gmail.com edited the test plan for this revision. (Show Details)

Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptDec 7 2015, 7:00 AM

Herald added subscribers: andrew, imp. · View Herald Transcript

howard0su_gmail.com added reviewers: rwatson, mmel, andrew.Dec 7 2015, 9:20 AM

andrew added inline comments.Dec 8 2015, 8:01 PM

sys/cddl/dev/fbt/arm/fbt_isa.c
45 ↗	(On Diff #10841)	This should be `#define<tab>FBT_SUBSP`
119 ↗	(On Diff #10841)	This mask should become a macro.
123 ↗	(On Diff #10841)	why `0x4000`?

Address review comments.

howard0su_gmail.com marked 2 inline comments as done.Dec 9 2015, 5:01 AM

howard0su_gmail.com added inline comments.

sys/cddl/dev/fbt/arm/fbt_isa.c
120 ↗	(On Diff #10955)	we have different mask here one is fffff000 the another is 0xffff0000. And below code uses 0xff000000. It is hard to give meaningful names to those masks.