java/eclipse: prevent conflict install devel/git@lite if devel/git already installed

[vvd]

Summary

Added options for pick git flavour.
Default lite as was before.

[vvd]

Other solution can be create USES=git with default value lite.

[michaelo]

java/eclipse/Makefile

20

Isn't mvn:devel/maven sufficient?

83

Can't we pick the one installed, thus leaving the decision the one compiling this port?

[vvd]

java/eclipse/Makefile

20

There are maven 3.6, 3.8 and 3.9 in ports. Maybe it require exactly 3.8 even if installed as default another version.
It's my assumption.

83

If you know how to do this, please suggest how.

[michaelo]

java/eclipse/Makefile

20

There is no default version for Maven because there is no USES for Maven. devel/maven is Maven 3.8.x. 3.9 contains some incompat changes of which I was not in favor of (which I have expressed to other committers) and that is why it is its own port devel/maven39. Regardless of this you can install those versions side by side as long as you use the absolute path to the for building Eclipse.

83

Not possible at the moment. Same was with Ghostscript 10: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272541, more specifically https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272541#c2.

But in this case what I wouldn't not do is to use the non-default flavor as option default. Which will pkg install with pkg install git? default I guess.

[vvd]

java/eclipse/Makefile

20

mvn:devel/maven-wrapper not mvn:devel/maven.
devel/maven have RUN_DEPENDS=mvn:devel/maven-wrapper.

Maybe maven>0:devel/maven is better for java/eclipse.

83

Agree with you!
But this is not my port and it was not my decission.
But this port is without maintainer, so I can change default option if you think it's better pick.

Also: devel/git@lite vs devel/git@default difference is less than measurement error during build java/eclipse.

[michaelo]

java/eclipse/Makefile

20

mvn:devel/maven-wrapper is not what you think. This is purely technical port for versoin selection at runtime, but does not depend on any physical Maven version. Don't depend on it.

I'd stick to mvn:devel/maven for the time being unless it explicitly requires 3.9.x.

83

My personal option, I'd say so. Let's see what others say.

[vvd]

java/eclipse/Makefile

20

I know what is devel/maven-wrapper port (same as other *-wrapper ports).
But is mvn:devel/maven work if where is no bin/mvn in mvn:devel/maven?
bin/mvn is in devel/maven-wrapper only.

[michaelo]

java/eclipse/Makefile

20

Then I agree with you that is has to be maven>0:devel/maven.

[vvd]

Ok, waiting comments from my mentors.

[michaelo]

I will take care of these:

osipovmi@deblndw011x:~/var/Projekte/freebsd/ports (main =)
$ grep -r --include='*/Makefile*' devel/maven .
./cad/digital/Makefile:BUILD_DEPENDS=   mvn:devel/maven
./devel/spark/Makefile:         mvn:devel/maven
./games/coronapoker/Makefile:BUILD_DEPENDS=     mvn:devel/maven
./games/jinput/Makefile:                mvn:devel/maven
./games/jutils/Makefile:BUILD_DEPENDS=  mvn:devel/maven
./games/lizzie/Makefile:BUILD_DEPENDS=  mvn:devel/maven
./math/jacop/Makefile:BUILD_DEPENDS=    mvn:devel/maven
./math/jts/Makefile:BUILD_DEPENDS=      mvn:devel/maven
./net-im/jicofo/Makefile:BUILD_DEPENDS= mvn:devel/maven
./net-im/jitsi-videobridge/Makefile:BUILD_DEPENDS=      mvn:devel/maven
./net-im/openfire/Makefile:BUILD_DEPENDS=       mvn:devel/maven
./science/cdk/Makefile:BUILD_DEPENDS=   mvn:devel/maven
./science/opsin/Makefile:BUILD_DEPENDS= mvn:devel/maven
./security/owasp-dependency-check/Makefile:BUILD_DEPENDS=       mvn:devel/maven
./sysutils/apache-mesos/Makefile:JAVA_BUILD_DEPENDS=    mvn:devel/maven
./sysutils/apache-mesos/Makefile:JAVA_FETCH_DEPENDS=    mvn:devel/maven
./sysutils/jvmtop/Makefile:BUILD_DEPENDS=       mvn:devel/maven

[michaelo]

FTR: https://reviews.freebsd.org/D44229

[michaelo]

@vvd, do you want to update this review?

[vvd]

In D44153#1011283, @michaelo wrote:

@vvd, do you want to update this review?

Look like it isn't actual anymore.