OFW: Add helper function for parsing PCI "ranges" property.
AbandonedPublic
Actions

Authored by mmel on Dec 3 2015, 12:19 PM.

Details

Reviewers

kib
nwhitehorn
andrew
imp

Summary

This function is needed for (nearly) all OFW PCI(e) drivers.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mmel updated this revision to Diff 10694.Dec 3 2015, 12:19 PM

mmel retitled this revision from to OFW: Add helper function for parsing PCI "ranges" property..

mmel updated this object.

mmel edited the test plan for this revision. (Show Details)

mmel added reviewers: imp, nwhitehorn, andrew, kib.

mmel set the repository for this revision to rS FreeBSD src repository - subversion.

mmel added a project: ARM.

What pci drivers do we have that could use this?

sys/dev/ofw/ofw_pci.c
112	It looks a bit odd using `(ranges)[i]` som any times, perhaps create a variable to point at `ranges`?

I'm not 100% sure, but probably all arm PCIe drivers have 'ranges' property. To be specific, each one who have I/O, memory and/or config space mapped to fixed (or configurable) address in host address space.

sys/dev/ofw/ofw_pci.c
112	oki, i will do it

On PPC, instead of a utility function, we have a common newbus base class that does this (powerpc/ofw/ofw_pci*). These remove 99% of the boilerplate from PCI bus drivers as well. I'd prefer that approach on ARM to new functions.

Yes, it's definitely better way.