Page MenuHomeFreeBSD

bintrans: Error out if writing to the output failed.
ClosedPublic

Authored by des on Jan 21 2024, 5:37 PM.
Tags
None
Referenced Files
F153379365: D43532.id133115.diff
Mon, Apr 20, 7:46 PM
F153376655: D43532.id133690.diff
Mon, Apr 20, 7:28 PM
F153315839: D43532.id133115.diff
Mon, Apr 20, 10:41 AM
F153256300: D43532.diff
Mon, Apr 20, 2:35 AM
F153224713: D43532.id133115.diff
Sun, Apr 19, 10:10 PM
Unknown Object (File)
Wed, Apr 15, 3:46 AM
Unknown Object (File)
Sun, Apr 12, 12:17 AM
Unknown Object (File)
Sun, Apr 12, 12:13 AM
Subscribers

Details

Summary
  • Cover all code paths.
  • When decoding, check all output files, not just the last one.
  • A simple ferror() check is not enough as an error may later occur while flushing whatever remains in the output buffer.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jan 21 2024, 5:37 PM

This needs a little more work as base64_decode() may return early.

fix decode cases correctly

allanjude added a subscriber: allanjude.

Reviewed-by: allanjude

This revision is now accepted and ready to land.Jan 31 2024, 2:40 PM