Page MenuHomeFreeBSD

bintrans: Error out if writing to the output failed.
ClosedPublic

Authored by des on Jan 21 2024, 5:37 PM.
Tags
None
Referenced Files
F166664996: D43532.id133115.diff
Sat, Aug 15, 8:55 AM
Unknown Object (File)
Thu, Aug 13, 1:04 AM
Unknown Object (File)
Wed, Aug 12, 10:04 PM
Unknown Object (File)
Wed, Aug 12, 9:50 PM
Unknown Object (File)
Wed, Aug 12, 9:49 PM
Unknown Object (File)
Wed, Aug 12, 9:35 PM
Unknown Object (File)
Wed, Aug 12, 8:27 PM
Unknown Object (File)
Wed, Aug 12, 4:41 PM
Subscribers

Details

Summary
  • Cover all code paths.
  • When decoding, check all output files, not just the last one.
  • A simple ferror() check is not enough as an error may later occur while flushing whatever remains in the output buffer.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jan 21 2024, 5:37 PM

This needs a little more work as base64_decode() may return early.

fix decode cases correctly

allanjude added a subscriber: allanjude.

Reviewed-by: allanjude

This revision is now accepted and ready to land.Jan 31 2024, 2:40 PM