Page MenuHomeFreeBSD

bintrans: Error out if writing to the output failed.
ClosedPublic

Authored by des on Jan 21 2024, 5:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 28, 7:15 PM
Unknown Object (File)
Sun, Sep 20, 4:57 PM
Unknown Object (File)
Sat, Sep 19, 1:59 PM
Unknown Object (File)
Sat, Sep 12, 2:44 PM
Unknown Object (File)
Fri, Sep 11, 11:17 AM
Unknown Object (File)
Aug 28 2026, 1:29 PM
Unknown Object (File)
Aug 27 2026, 4:34 PM
Unknown Object (File)
Aug 24 2026, 8:17 AM
Subscribers

Details

Summary
  • Cover all code paths.
  • When decoding, check all output files, not just the last one.
  • A simple ferror() check is not enough as an error may later occur while flushing whatever remains in the output buffer.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jan 21 2024, 5:37 PM

This needs a little more work as base64_decode() may return early.

fix decode cases correctly

allanjude added a subscriber: allanjude.

Reviewed-by: allanjude

This revision is now accepted and ready to land.Jan 31 2024, 2:40 PM