mpr: Handle errors from copyout() in ioctl handlers
ClosedPublic
Actions

Authored by markj on Dec 25 2023, 5:58 PM.

Details

Reviewers

asomers
imp
ken
slm

Commits

rG4392ef59412d: mpr: Handle errors from copyout() in ioctl handlers
rGd60d9b713a46: mpr: Handle errors from copyout() in ioctl handlers
rG68cc77a3b73f: mpr: Handle errors from copyout() in ioctl handlers

Summary

In preparation for adding a __result_use_check annotation to copyin()
and related functions, start checking for errors from copyout() in
the mpr(4) user command handler. This should make it easier to catch
bugs.

MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 25 2023, 5:58 PM

Herald added a reviewer: slm. · View Herald TranscriptDec 25 2023, 5:58 PM

markj requested review of this revision.Dec 25 2023, 5:58 PM

Harbormaster completed remote builds in B55107: Diff 131834.Dec 25 2023, 5:58 PM

markj added a parent revision: D43176: mps: Handle errors from copyout() in ioctl handlers.Dec 25 2023, 5:58 PM

asomers accepted this revision.Dec 25 2023, 6:18 PM

This revision is now accepted and ready to land.Dec 25 2023, 6:18 PM

imp accepted this revision.Dec 25 2023, 6:23 PM

Closed by commit rG68cc77a3b73f: mpr: Handle errors from copyout() in ioctl handlers (authored by markj). · Explain WhyDec 26 2023, 2:05 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG68cc77a3b73f: mpr: Handle errors from copyout() in ioctl handlers.

markj added a commit: rGd60d9b713a46: mpr: Handle errors from copyout() in ioctl handlers.Jan 2 2024, 12:39 AM

markj added a commit: rG4392ef59412d: mpr: Handle errors from copyout() in ioctl handlers.Jan 2 2024, 1:16 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

mpr/

mpr_user.c

39 lines

Diff 131853

View Options

mpr: Handle errors from copyout() in ioctl handlersClosedPublicActions