Page MenuHomeFreeBSD
Differential D43101

freebsd32: Report errors when copying out oldlenp in __sysctl
ClosedPublic
Actions

Authored by markj on Dec 19 2023, 3:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 12, 1:39 PM
Unknown Object (File)
Fri, Sep 11, 4:51 PM
Unknown Object (File)
Wed, Sep 9, 12:30 AM
Unknown Object (File)
Sat, Sep 5, 12:34 PM
Unknown Object (File)
Sat, Sep 5, 9:08 AM
Unknown Object (File)
Sat, Sep 5, 3:35 AM
Unknown Object (File)
Fri, Sep 4, 8:40 PM
Unknown Object (File)
Fri, Sep 4, 5:58 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rG573b117f6e30: freebsd32: Report errors when copying out oldlenp in __sysctl
rG8fa808af6fb9: freebsd32: Report errors when copying out oldlenp in __sysctl
rG81eb7baa69e9: freebsd32: Report errors when copying out oldlenp in __sysctl
Summary

This matches the native implementation's behaviour.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Dec 19 2023, 3:14 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 19 2023, 3:14 AM
markj requested review of this revision.Dec 19 2023, 3:14 AM
Harbormaster completed remote builds in B55007: Diff 131552.Dec 19 2023, 3:14 AM
kib added inline comments.Dec 19 2023, 8:02 AM
sys/compat/freebsd32/freebsd32_misc.c
2679

Shouldn't this be converted from -1 to EFAULT?

markj updated this revision to Diff 131581.Dec 19 2023, 3:59 PM
markj marked an inline comment as done.

Fix error handling

Harbormaster completed remote builds in B55031: Diff 131581.Dec 19 2023, 3:59 PM
markj added inline comments.Dec 19 2023, 3:59 PM
sys/compat/freebsd32/freebsd32_misc.c
2679

Indeed, thank you. sysctlbyname had the same bug. In fact, I found several examples with a quick search.

kib accepted this revision.Dec 19 2023, 4:22 PM
This revision is now accepted and ready to land.Dec 19 2023, 4:22 PM
Closed by commit rG81eb7baa69e9: freebsd32: Report errors when copying out oldlenp in __sysctl (authored by markj). · Explain WhyDec 26 2023, 2:04 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG81eb7baa69e9: freebsd32: Report errors when copying out oldlenp in __sysctl.
markj added a commit: rG8fa808af6fb9: freebsd32: Report errors when copying out oldlenp in __sysctl.Jan 2 2024, 12:38 AM
markj added a commit: rG573b117f6e30: freebsd32: Report errors when copying out oldlenp in __sysctl.Jan 2 2024, 1:14 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
freebsd32/
6 lines

Diff 131838

View Options

sys/compat/freebsd32/freebsd32_misc.c

Loading...