Page MenuHomeFreeBSD

LinuxKPI: Add linux/ioport.h header
ClosedPublic

Authored by wulf on Nov 28 2023, 9:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 7:57 PM
Unknown Object (File)
Mon, Oct 6, 6:18 AM
Unknown Object (File)
Sun, Oct 5, 12:21 AM
Unknown Object (File)
Fri, Sep 26, 10:56 PM
Unknown Object (File)
Thu, Sep 25, 1:40 AM
Unknown Object (File)
Mon, Sep 22, 11:35 PM
Unknown Object (File)
Mon, Sep 22, 3:56 PM
Unknown Object (File)
Sep 11 2025, 1:00 AM

Details

Summary

Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf requested review of this revision.Nov 28 2023, 9:17 PM
bz requested changes to this revision.Dec 8 2023, 5:50 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/ioport.h
11

"long" is Linux-style. I would not want to have to implement compat like this.

If this is all we need this for I am pondering if it is worth redefining this "resource" to "linux_resource"?

This revision now requires changes to proceed.Dec 8 2023, 5:50 PM
wulf edited the summary of this revision. (Show Details)

Use drm-kmod version of linux/ioport.h placed in https://github.com/freebsd/drm-kmod/blob/master/linuxkpi/gplv2/include/linux/pci.h as a base.
It properly defines members of struct resource.

sys/compat/linuxkpi/common/include/linux/ioport.h
11

We defines "resource" as "linux_resource" for long time. But the problem is structure members called "resource" e.g.: https://github.com/freebsd/drm-kmod/blob/master/include/drm/ttm/ttm_bo_api.h#L138 . We have to fix the too as compilation becomes depending on header order.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 24 2023, 8:29 AM
This revision was automatically updated to reflect the committed changes.