LinuxKPI: Add ida_alloc_min()
ClosedPublic
Actions

Authored by wulf on Nov 28 2023, 9:05 PM.

Details

Reviewers

manu
dumbbell
bz

Commits

rGfcfc3fe00d32: LinuxKPI: Add ida_alloc_min()
rGc7312643b7e5: LinuxKPI: Add ida_alloc_min()

Summary

ida_alloc_min() allocates an unused ID. between min and INT_MAX.

Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Nov 28 2023, 9:05 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptNov 28 2023, 9:05 PM

wulf requested review of this revision.Nov 28 2023, 9:05 PM

Harbormaster completed remote builds in B54662: Diff 130691.Nov 28 2023, 9:05 PM

wulf added a reviewer: bz.Nov 28 2023, 10:44 PM

manu accepted this revision.Nov 29 2023, 6:12 AM

This revision is now accepted and ready to land.Nov 29 2023, 6:12 AM

bz requested changes to this revision.Dec 8 2023, 5:28 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/idr.h
138	INT_MAX or UINT_MAX given min is unsigned or should that be just int?

This revision now requires changes to proceed.Dec 8 2023, 5:28 PM

INT_MAX -> UINT_MAX

wulf marked an inline comment as done.Dec 9 2023, 12:06 PM

wulf added inline comments.

sys/compat/linuxkpi/common/include/linux/idr.h
138	I set INT_MAX due to misleading comment in Linux header. Actual code uses ~0u AKA UINT_MAX

allow end parameter of ida_simple_get() be larger than INT_MAX. Linux caps the value to INT_MAX.

bz accepted this revision.Dec 12 2023, 1:38 AM

This revision is now accepted and ready to land.Dec 12 2023, 1:38 AM

Closed by commit rGc7312643b7e5: LinuxKPI: Add ida_alloc_min() (authored by wulf). · Explain WhyDec 24 2023, 8:24 AM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rGc7312643b7e5: LinuxKPI: Add ida_alloc_min().

wulf added a commit: rGfcfc3fe00d32: LinuxKPI: Add ida_alloc_min().Feb 17 2024, 9:34 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

idr.h

7 lines

src/

linux_idr.c

5 lines

Diff 131779

View Options

sys/compat/linuxkpi/common/include/linux/idr.h