Differential D42796

LinuxKPI: Add linux/container_of.h header
ClosedPublic
Actions

Authored by wulf on Nov 28 2023, 8:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 8, 11:32 AM

	Unknown Object (File)
	Wed, May 8, 11:31 AM

	Unknown Object (File)
	Wed, May 8, 11:31 AM

	Unknown Object (File)
	Wed, May 8, 11:31 AM

	Unknown Object (File)
	Wed, May 8, 9:26 AM

	Unknown Object (File)
	Tue, May 7, 3:05 AM

	Unknown Object (File)
	Apr 6 2024, 11:28 AM

	Unknown Object (File)
	Mar 21 2024, 3:44 AM

View All 22 Files

Subscribers

Details

Reviewers

manu
dumbbell
bz

Commits

rG21d85c41bbbb: LinuxKPI: Split linux/container_of.h off from linux/kernel.h
rGfa862482fb0a: LinuxKPI: Split linux/container_of.h off from linux/kernel.h

Summary

Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Nov 28 2023, 8:47 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptNov 28 2023, 8:47 PM

wulf requested review of this revision.Nov 28 2023, 8:47 PM

Harbormaster completed remote builds in B54652: Diff 130681.Nov 28 2023, 8:47 PM

wulf added a reviewer: bz.Nov 28 2023, 10:39 PM

manu accepted this revision.Nov 29 2023, 6:09 AM

This revision is now accepted and ready to land.Nov 29 2023, 6:09 AM

bz requested changes to this revision.Dec 8 2023, 5:01 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/container_of.h
2	I am not sure you can do that given the majority of the file was taken from a different Copyright and Licensed file.
4	_LINUXKPI_LINUX_..
9	Also please really preserve the original wrapping. In general our implementation and adjustments are older than the ones I looked up in OpenBSD so please preserve them.
11	Either way you need to include something here (also for offsetoff and uintptr_t above). typeof lives in compiler.h; funny enough we have a TYPEOF_MEMBER in sys/sys/stats.h but __typeof() could just be used?

This revision now requires changes to proceed.Dec 8 2023, 5:01 PM

Add LINUXKPI to guard #define
Use FreeBSD container_of implementation
typeof -> __typeof
Not based on OpenBSD version now

Add prequisite includes

remove duplicated typeof_member from linux/kernel.h

bz accepted this revision.Dec 12 2023, 1:43 AM

This revision is now accepted and ready to land.Dec 12 2023, 1:43 AM

Closed by commit rGfa862482fb0a: LinuxKPI: Split linux/container_of.h off from linux/kernel.h (authored by wulf). · Explain WhyDec 24 2023, 8:23 AM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rGfa862482fb0a: LinuxKPI: Split linux/container_of.h off from linux/kernel.h.

wulf added a commit: rG21d85c41bbbb: LinuxKPI: Split linux/container_of.h off from linux/kernel.h.Feb 17 2024, 9:34 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

46 lines

9 lines

Diff 131770

sys/compat/linuxkpi/common/include/linux/container_of.h

Loading...

sys/compat/linuxkpi/common/include/linux/kernel.h

Loading...