Do not install kernel and modules as executables, they are not
ClosedPublic
Actions

Authored by kib on Nov 25 2023, 1:50 PM.

Details

Reviewers

imp
emaste
kevans

Commits

rGa9758e46473b: Do not install kernel and modules with executable access bit set
rGd3849ec3c9e7: Set installed kernel and driver files access modes using KMODMODE var

Summary

Also set installed kernel and driver files access modes using KMODMODE var

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Nov 25 2023, 1:50 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptNov 25 2023, 1:50 PM

kib requested review of this revision.Nov 25 2023, 1:50 PM

As far as I know, neither the boot loader, nor the kld system calls will check.
I can't think of anything that will get cranky over this change...

This revision is now accepted and ready to land.Nov 25 2023, 5:05 PM

emaste accepted this revision.Nov 25 2023, 5:18 PM

Closed by commit rGd3849ec3c9e7: Set installed kernel and driver files access modes using KMODMODE var (authored by kib). · Explain WhyNov 25 2023, 6:48 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGd3849ec3c9e7: Set installed kernel and driver files access modes using KMODMODE var.

kib added a commit: rGa9758e46473b: Do not install kernel and modules with executable access bit set.

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.own.mk

2 lines

sys/

conf/

kern.post.mk

10 lines

Diff 130574

View Options

share/mk/bsd.own.mk