Page MenuHomeFreeBSD

textproc/jq: Use tarball published by upstream
ClosedPublic

Authored by jrm on Nov 24 2023, 6:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 10:41 AM
Unknown Object (File)
Mon, Jun 24, 10:04 AM
Unknown Object (File)
May 15 2024, 4:19 PM
Unknown Object (File)
May 8 2024, 9:20 AM
Unknown Object (File)
May 8 2024, 9:20 AM
Unknown Object (File)
May 8 2024, 6:50 AM
Unknown Object (File)
May 8 2024, 6:49 AM
Unknown Object (File)
Jan 23 2024, 2:09 PM
Subscribers

Details

Summary

This also fixes an issue with jq --version not reporting the version.
While here, also pet portclippy/portfmt/portlint.

Reported by: Vedran Miletic <vedran@miletic.net>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm requested review of this revision.Nov 24 2023, 6:21 PM
jrm created this revision.

If so, the project has moved: https://github.com/jqlang/jq

This revision now requires changes to proceed.Nov 24 2023, 6:25 PM

Use new upstream site rather than relying on forwarding

It was using USE_GITHUB, but I switched it to fix the issue with jq --version and also because of the warning at the top of that page you just shared.

In D42758#975376, @jrm wrote:

It was using USE_GITHUB, but I switched it to fix the issue with jq --version and also because of the warning at the top of that page you just shared.

Indeed, then we have a ports framework issue. Different discussion.

This revision is now accepted and ready to land.Nov 24 2023, 6:43 PM

That's a "last resort" solution, use release tarballs/archives whenever possible.

Usually when version information is missing it's because upstream's framework relies on Git to figure out what version is being built (this is usually adjusted in release archives in one way or another) and Git is usually not called in the correct path anyway so it fails or reports incorrectly.
In this case it seems like this script is being used to determine version: https://github.com/jqlang/jq/blob/master/scripts/version and since we don't download .git it fails.

This isn't a framework bug rather a limitation of upstream's build script but since upstream now (as of 1.4) ships release tarballs which handles this issue there's nothing to fix.