Differential D42746

kern: bootverbose around printfs
Needs ReviewPublic
Actions

Authored by oskar.holmlund_ohdata.se on Nov 24 2023, 8:09 AM.

Details

Reviewers

manu

Summary

As far as I can find in current codebase:
et_quality is only assigned positive values

tc_quality can be negative (in sys/x86/x86/tsc.c)

But it feels reasonable to use AND in the ifstatements instead of OR.

Remove dead if-statment

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

oskar.holmlund_ohdata.se created this revision.Nov 24 2023, 8:09 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2023, 8:09 AM

oskar.holmlund_ohdata.se requested review of this revision.Nov 24 2023, 8:09 AM

zlei added subscribers: phk, zlei.Nov 24 2023, 10:03 AM

zlei added inline comments.

sys/kern/kern_et.c

I think it is wrong.

Currently we have event timer report on dmesg:

# dmesg | grep 'Event timer'
Event timer "LAPIC" quality 600
Event timer "i8254" frequency 1193182 Hz quality 100
Event timer "HPET" frequency 14318180 Hz quality 550
Event timer "HPET1" frequency 14318180 Hz quality 440
Event timer "HPET2" frequency 14318180 Hz quality 440
Event timer "HPET3" frequency 14318180 Hz quality 440
Event timer "HPET4" frequency 14318180 Hz quality 440
Event timer "RTC" frequency 32768 Hz quality 0

With this change they are not reported any longer (without bootverbose).

sys/kern/kern_tc.c

2120

This is disabled intentionally by @phk in 590487078fe5 (Disable the "cputick increased..." message now that the dust has settled)