Page MenuHomeFreeBSD
Differential D42707

getpagesizes(3): drop support for kernels before 9.0
ClosedPublic
Actions

Authored by brooks on Nov 22 2023, 1:08 AM.
Tags
None
Referenced Files
F84171606: D42707.diff
Mon, May 20, 9:06 AM
Unknown Object (File)
Thu, Apr 25, 1:42 AM
Unknown Object (File)
Thu, Apr 25, 1:42 AM
Unknown Object (File)
Thu, Apr 25, 1:41 AM
Unknown Object (File)
Thu, Apr 25, 1:41 AM
Unknown Object (File)
Thu, Apr 25, 1:28 AM
Unknown Object (File)
Jan 19 2024, 7:47 PM
Unknown Object (File)
Jan 19 2024, 7:44 PM
View All 18 Files
Subscribers
None

Details

Reviewers
imp
emaste
kevans
Commits
rGdf65c89375e2: getpagesizes(3): drop support for kernels before 9.0
Summary

AT_PAGESIZES and elf_aux_info where added prior to FreeBSD 9.0 in commit
ee235befcb8253fab9beea27b916f1bc46b33147. It's safe to say that a
FreeBSD 15 libc won't work on a 8.x kernel so drop sysctl fallback.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54555
Build 51444: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Nov 22 2023, 1:08 AM
brooks created this revision.
Harbormaster completed remote builds in B54555: Diff 130410.Nov 22 2023, 1:08 AM
brooks added a child revision: D42708: getpagesize(3): drop support for non-ELF kernels.Nov 22 2023, 1:08 AM
emaste accepted this revision.Nov 22 2023, 1:21 AM
emaste added inline comments.
lib/libc/gen/getpagesizes.c
60–61

LGTM, but maybe drop error altogether and just if (_elf_aux_info(AT_PAGESIZES, ps, sizeof(ps) != 0)?

This revision is now accepted and ready to land.Nov 22 2023, 1:21 AM
imp accepted this revision.Nov 22 2023, 1:46 AM
kevans accepted this revision.Nov 22 2023, 5:43 AM
brooks updated this revision to Diff 130444.Nov 22 2023, 8:31 PM
  • Remove error variable
  • On error, fall back to PAGE_SIZE
This revision now requires review to proceed.Nov 22 2023, 8:31 PM
Harbormaster completed remote builds in B54578: Diff 130444.Nov 22 2023, 8:31 PM
emaste accepted this revision.Nov 22 2023, 10:15 PM
This revision is now accepted and ready to land.Nov 22 2023, 10:15 PM
Closed by commit rGdf65c89375e2: getpagesizes(3): drop support for kernels before 9.0 (authored by brooks). · Explain WhyNov 28 2023, 5:16 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGdf65c89375e2: getpagesizes(3): drop support for kernels before 9.0.

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
20 lines

Diff 130410

View Options

lib/libc/gen/getpagesizes.c

Loading...