arm64: Initialize x18 for APs earlier during boot

[markj]

Summary

When KMSAN is configured, the instrumentation inserts calls to
__msan_get_context_state() into all function prologues. The
implementation dereferences curthread and thus assumes that x18 points
to the PCPU area. This applies in particular to init_secondary(), which
currently is responsible for initializing x18 for APs.

Move initialization into locore to avoid this problem. No functional
change intended.

Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

[andrew]

sys/arm64/arm64/locore.S

254–255

We can remove a pc-relative load & replace it with what is essentially an add. I have a local patch to clean up other places we use ldr, xn, =foo ldr xn, [xn].

[markj]

Apply Andy's suggestion