llvm: Reduce overlinking with the minimal llvm
ClosedPublic
Actions

Authored by andrew on Nov 9 2023, 2:46 PM.

Details

Reviewers

Commits

rG29d1d72ad529: llvm: Reduce overlinking with the minimal llvm
rG2f3b605b2e15: llvm: Reduce overlinking with the minimal llvm
rG83771b1914e1: llvm: Reduce overlinking with the minimal llvm

Summary

We only need to link against libz and libzstd when linking against the
fill libllvm, libllvmminimal doesn't use either library. Move adding
libz and libzstd to the list of libraries to link against to where
we decide to use the full libllvm.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54351
Build 51241: arc lint + arc unit

Event Timeline

andrew created this revision.Nov 9 2023, 2:46 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 9 2023, 2:46 PM

andrew requested review of this revision.Nov 9 2023, 2:46 PM

Harbormaster completed remote builds in B54351: Diff 129900.Nov 9 2023, 2:46 PM

Hmm are you sure this works? I remember that it failed when you built the bootstap tblgen variants, and I think I ran into that again when doing the llvm-17-update branch.

I tested a native buildworld of main from 13.2, default GitHub cross build [1], and a GitHub cross build where I forced -j1. I haven't seen any issues where they failed to build.

[1] https://github.com/zxombie/freebsd/actions/runs/6813523900
[2] https://github.com/zxombie/freebsd/actions/runs/6813861833