Page MenuHomeFreeBSD
Differential D42499

crunchgen: make special "keep" more useful, break it out
ClosedPublic
Actions

Authored by kevans on Nov 8 2023, 6:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 16 2024, 11:01 PM
Unknown Object (File)
Mar 9 2024, 2:33 PM
Unknown Object (File)
Mar 9 2024, 2:33 PM
Unknown Object (File)
Mar 9 2024, 2:33 PM
Unknown Object (File)
Mar 9 2024, 2:18 PM
Unknown Object (File)
Dec 28 2023, 4:29 PM
Unknown Object (File)
Dec 28 2023, 4:29 PM
Unknown Object (File)
Dec 28 2023, 4:29 PM
View All 23 Files
Subscribers
bdrewery
emaste

Details

Reviewers
imp
adrian
Commits
rG8f2848eafa68: crunchgen: fix "keep" for an ELF world, break it out
Summary

Right now this prepends a leading underscore, but it's not clear that
it's even used. Preserve the symbol as it comes in instead to make it
more generically useful.

While we're here, break it out to bsd.crunchgen.mk for later use in
bsdbox.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Nov 8 2023, 6:34 AM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptNov 8 2023, 6:34 AM
kevans requested review of this revision.Nov 8 2023, 6:34 AM
Harbormaster completed remote builds in B54326: Diff 129844.Nov 8 2023, 6:34 AM
kevans added a parent revision: D42498: bsdbox: fix the build.Nov 8 2023, 6:34 AM
kevans added a child revision: D42500: bsdbox: fix the hostapd build, hook it back up.
imp accepted this revision.Nov 8 2023, 10:49 AM
imp added inline comments.
usr.sbin/crunch/crunchgen/crunchgen.c
1131

A.out did this for symbol names. I wonder why it didn't die in FreeBSD 3.2

This revision is now accepted and ready to land.Nov 8 2023, 10:49 AM
adrian accepted this revision.Nov 8 2023, 4:02 PM
kevans added inline comments.Nov 8 2023, 4:10 PM
usr.sbin/crunch/crunchgen/crunchgen.c
1131

Oh, thanks for that context. In that case, I'm just going to drop the UPDATING completely and maybe flag it in relnotes at most.

Closed by commit rG8f2848eafa68: crunchgen: fix "keep" for an ELF world, break it out (authored by kevans). · Explain WhyNov 10 2023, 4:34 AM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG8f2848eafa68: crunchgen: fix "keep" for an ELF world, break it out.

Revision Contents
Changeset List

PathSize
share/
mk/
4 lines
usr.sbin/
crunch/
crunchgen/
2 lines

Diff 129923

View Options

share/mk/bsd.crunchgen.mk

Loading...
View Options

usr.sbin/crunch/crunchgen/crunchgen.c

Loading...