Page MenuHomeFreeBSD
Differential D42287

riscv: Retire PMAP_INLINE
ClosedPublic
Actions

Authored by markj on Oct 19 2023, 1:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 7:02 AM
Unknown Object (File)
Tue, Apr 30, 5:48 AM
Unknown Object (File)
Tue, Apr 30, 5:48 AM
Unknown Object (File)
Tue, Apr 30, 5:06 AM
Unknown Object (File)
Mon, Apr 29, 10:08 PM
Unknown Object (File)
Fri, Apr 26, 1:09 PM
Unknown Object (File)
Fri, Apr 26, 12:34 AM
Unknown Object (File)
Mon, Apr 22, 3:07 PM
View All 22 Files
Subscribers
imp
riscv

Details

Reviewers
alc
kib
jhb
Commits
rG00c537586fdf: riscv: Retire PMAP_INLINE
rG953345922398: riscv: Retire PMAP_INLINE
Summary

pmap_kremove() is not called from within pmap.c, so there's no reason to
inline it. No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Oct 19 2023, 1:07 PM
Herald added subscribers: riscv, imp. · View Herald TranscriptOct 19 2023, 1:07 PM
markj requested review of this revision.Oct 19 2023, 1:07 PM
Harbormaster completed remote builds in B54079: Diff 129079.Oct 19 2023, 1:07 PM
markj added a child revision: D42288: riscv: Port improvements from arm64/amd64 pmaps, part 1.Oct 19 2023, 1:07 PM
markj mentioned this in D41633: riscv pmap: allocate leaf page table page for wired userspace superpages.Oct 19 2023, 6:38 PM
kib accepted this revision.Oct 20 2023, 4:02 PM

Can we do the same for x86?

This revision is now accepted and ready to land.Oct 20 2023, 4:02 PM
alc accepted this revision.Oct 20 2023, 4:09 PM
markj added a comment.Nov 2 2023, 3:38 PM
In D42287#965564, @kib wrote:

Can we do the same for x86?

I think it would be reasonable: clang does not define __GNUC_GNU_INLINE__, so by default PMAP_INLINE is just inline.

Closed by commit rG953345922398: riscv: Retire PMAP_INLINE (authored by markj). · Explain WhyNov 2 2023, 6:47 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG953345922398: riscv: Retire PMAP_INLINE.
markj added a commit: rG00c537586fdf: riscv: Retire PMAP_INLINE.Nov 9 2023, 2:40 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
riscv/
12 lines

Diff 129659

View Options

sys/riscv/riscv/pmap.c

Loading...