Page MenuHomeFreeBSD

riscv: Retire PMAP_INLINE
ClosedPublic

Authored by markj on Oct 19 2023, 1:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 18, 9:40 AM
Unknown Object (File)
Sun, Feb 18, 9:40 AM
Unknown Object (File)
Sun, Feb 18, 9:40 AM
Unknown Object (File)
Sun, Feb 18, 9:33 AM
Unknown Object (File)
Dec 29 2023, 1:26 PM
Unknown Object (File)
Dec 20 2023, 8:29 AM
Unknown Object (File)
Dec 9 2023, 11:59 PM
Unknown Object (File)
Nov 30 2023, 5:37 AM
Subscribers

Details

Summary

pmap_kremove() is not called from within pmap.c, so there's no reason to
inline it. No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Oct 19 2023, 1:07 PM

Can we do the same for x86?

This revision is now accepted and ready to land.Oct 20 2023, 4:02 PM
In D42287#965564, @kib wrote:

Can we do the same for x86?

I think it would be reasonable: clang does not define __GNUC_GNU_INLINE__, so by default PMAP_INLINE is just inline.

This revision was automatically updated to reflect the committed changes.