Page MenuHomeFreeBSD
Differential D42137

ping: Simplify protocol selection.
ClosedPublic
Actions

Authored by des on Oct 9 2023, 4:52 PM.
Tags
None
Referenced Files
F131780923: D42137.id128528.diff
Sat, Oct 11, 2:55 AM
Unknown Object (File)
Fri, Oct 10, 8:16 PM
Unknown Object (File)
Fri, Oct 10, 8:13 PM
Unknown Object (File)
Fri, Oct 10, 8:09 PM
Unknown Object (File)
Fri, Oct 10, 8:09 PM
Unknown Object (File)
Fri, Oct 10, 8:08 PM
Unknown Object (File)
Fri, Oct 10, 2:43 PM
Unknown Object (File)
Tue, Sep 23, 8:53 AM
View All Files
Subscribers
allanjude
imp

Details

Reviewers
rscheff
allanjude
kevans
Group Reviewers
Klara
Commits
rG8b55607a7fa3: ping: Simplify protocol selection.
rG0648be66c477: ping: Simplify protocol selection.
rG7fd2c91a291b: ping: Simplify protocol selection.
Summary
  • Interrupt the option loop as soon as we have an indication of which protocol is intended.
  • If we end up having to perform a DNS lookup, loop over the entire result looking for either IPv4 or IPv6 addresses.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Oct 9 2023, 4:52 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 9 2023, 4:52 PM
des requested review of this revision.Oct 9 2023, 4:52 PM
Harbormaster completed remote builds in B53904: Diff 128460.Oct 9 2023, 4:52 PM
rscheff accepted this revision.Oct 9 2023, 5:27 PM
This revision is now accepted and ready to land.Oct 9 2023, 5:27 PM
des updated this revision to Diff 128468.Oct 9 2023, 8:01 PM

fall through

This revision now requires review to proceed.Oct 9 2023, 8:01 PM
Harbormaster completed remote builds in B53906: Diff 128468.Oct 9 2023, 8:01 PM
des edited the summary of this revision. (Show Details)Oct 9 2023, 8:01 PM
allanjude accepted this revision.Oct 9 2023, 8:58 PM
allanjude added a subscriber: allanjude.

reviewed-by: allanjude

This revision is now accepted and ready to land.Oct 9 2023, 8:58 PM
des added inline comments.Oct 9 2023, 9:03 PM
sbin/ping/main.c
145–146

I can't make up my mind about this... if getaddrinfo() didn't return anything useful, that's not likely to change. Should I put the errx(1, "Unknown host") back? (above the #endif though)

des updated this revision to Diff 128504.Oct 10 2023, 2:30 PM

don't fall through

This revision now requires review to proceed.Oct 10 2023, 2:30 PM
Harbormaster completed remote builds in B53912: Diff 128504.Oct 10 2023, 2:30 PM
des edited the summary of this revision. (Show Details)Oct 10 2023, 2:31 PM
kevans accepted this revision.Oct 10 2023, 8:12 PM
This revision is now accepted and ready to land.Oct 10 2023, 8:12 PM
Closed by commit rG7fd2c91a291b: ping: Simplify protocol selection. (authored by des). · Explain WhyOct 10 2023, 10:48 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG7fd2c91a291b: ping: Simplify protocol selection..
des added a commit: rG0648be66c477: ping: Simplify protocol selection..Dec 13 2023, 8:09 PM
des added a commit: rG8b55607a7fa3: ping: Simplify protocol selection..

Revision Contents
Changeset List

PathSize
sbin/
ping/
125 lines
tests/
26 lines

Diff 128528

View Options

sbin/ping/main.c

Loading...
View Options

sbin/ping/tests/ping_test.sh

Loading...