Page MenuHomeFreeBSD

pkgbase: put library links and symlinks in the -dev package
ClosedPublic

Authored by dfr on Sep 13 2023, 10:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 6:21 PM
Unknown Object (File)
Sat, May 4, 2:34 PM
Unknown Object (File)
Sat, May 4, 8:23 AM
Unknown Object (File)
Tue, Apr 30, 8:41 PM
Unknown Object (File)
Tue, Apr 30, 8:41 PM
Unknown Object (File)
Tue, Apr 30, 8:28 PM
Unknown Object (File)
Tue, Apr 30, 8:27 PM
Unknown Object (File)
Tue, Apr 30, 6:39 PM

Details

Summary

Some libraries (e.g. ncurses) install links to the main library for
backwards compatibilty. This change ensures that those links are in the
dev package since the files being linked to are in that package.

PR: 249143
MFC after: 1 week

Test Plan

Run 'make packages', manually inspect packages to see that the symlinks are in the correct package.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53567
Build 50458: arc lint + arc unit

Event Timeline

dfr requested review of this revision.Sep 13 2023, 10:23 AM

I wonder if something like LINKTAGS=dev and then

.if defined(LINKTAGS)
        ${INSTALL_LINK} ${TAG_ARGS:D${TAG_ARGS},${LINKTAGS}} ${DESTDIR}${s} ${DESTDIR}${t}

is more clear?

I wonder if something like LINKTAGS=dev and then

.if defined(LINKTAGS)
        ${INSTALL_LINK} ${TAG_ARGS:D${TAG_ARGS},${LINKTAGS}} ${DESTDIR}${s} ${DESTDIR}${t}

is more clear?

I like it - I'll make that change and update the diff.

Use a new variable, LINKTAGS, to make the interface between bsd.lib.mk and bsd.links.mk clearer.

This revision is now accepted and ready to land.Sep 13 2023, 11:15 AM