Page MenuHomeFreeBSD

Fix zfsd with the device_removal pool feature.
ClosedPublic

Authored by asomers on Sep 12 2023, 1:26 AM.
Tags
None
Referenced Files
F137363526: D41818.id127277.diff
Sat, Nov 22, 7:39 PM
F137362156: D41818.id127259.diff
Sat, Nov 22, 7:26 PM
Unknown Object (File)
Sun, Nov 16, 7:41 AM
Unknown Object (File)
Sat, Nov 8, 10:48 AM
Unknown Object (File)
Sat, Nov 8, 7:40 AM
Unknown Object (File)
Fri, Nov 7, 11:19 AM
Unknown Object (File)
Thu, Nov 6, 10:14 PM
Unknown Object (File)
Wed, Nov 5, 11:49 PM
Subscribers

Details

Summary

Previously zfsd would crash in the presence of a pool with a
top-level-vdev that had previously been removed. The crash only happens
in stable/14 and later, probably do to differences in libcxx, but the
change should be MFCed anyway.

PR: 273663
Reported by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
MFC after: 1 week
Sponsored by: Axcient

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mav added inline comments.
cddl/usr.sbin/zfsd/vdev_iterator.cc
112

I personally would initialize vdevConfig above in declaration, but whatever.

This revision is now accepted and ready to land.Sep 12 2023, 1:39 PM