Page MenuHomeFreeBSD

Fix zfsd with the device_removal pool feature.
ClosedPublic

Authored by asomers on Sep 12 2023, 1:26 AM.
Tags
None
Referenced Files
F133847118: D41818.id127259.diff
Tue, Oct 28, 10:04 PM
F133810584: D41818.id127277.diff
Tue, Oct 28, 2:55 PM
F133807052: D41818.diff
Tue, Oct 28, 2:17 PM
Unknown Object (File)
Sat, Oct 18, 12:37 PM
Unknown Object (File)
Tue, Oct 14, 2:14 PM
Unknown Object (File)
Sat, Oct 11, 11:52 AM
Unknown Object (File)
Sat, Oct 11, 11:52 AM
Unknown Object (File)
Sat, Oct 11, 11:52 AM
Subscribers

Details

Summary

Previously zfsd would crash in the presence of a pool with a
top-level-vdev that had previously been removed. The crash only happens
in stable/14 and later, probably do to differences in libcxx, but the
change should be MFCed anyway.

PR: 273663
Reported by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
MFC after: 1 week
Sponsored by: Axcient

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mav added inline comments.
cddl/usr.sbin/zfsd/vdev_iterator.cc
112

I personally would initialize vdevConfig above in declaration, but whatever.

This revision is now accepted and ready to land.Sep 12 2023, 1:39 PM