Differential D41795

stand/loader.efi: fix regression with ignoring nvstore
ClosedPublic
Actions

Authored by glebius on Sep 9 2023, 4:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 6:02 PM

	Unknown Object (File)
	Tue, Oct 14, 6:02 PM

	Unknown Object (File)
	Tue, Oct 14, 6:10 AM

	Unknown Object (File)
	Mon, Oct 13, 4:42 PM

	Unknown Object (File)
	Sat, Oct 11, 7:15 AM

	Unknown Object (File)
	Sep 9 2025, 1:09 AM

	Unknown Object (File)
	Aug 5 2025, 12:06 AM

	Unknown Object (File)
	Jul 28 2025, 5:27 AM

View All 71 Files

Subscribers

Details

Reviewers

tsoome
imp
manu

Commits

rGebdd5d72fffc: stand/loader.efi: fix regression with ignoring nvstore
rGd13550f0c9c2: stand/loader.efi: fix regression with ignoring nvstore

Summary

We always need to call zfs_attach_nvstore() regardless of whether we
use bootonce key in nvstore or the bootfs property of the pool.

In particular this fixes broken 'nextboot -k'.

Fixes: e3e2681d0ec28d6661fef6da76c9479049e2761c

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Sep 9 2023, 4:21 AM

Herald added a reviewer: manu. · View Herald TranscriptSep 9 2023, 4:21 AM

Herald added subscribers: dab, bcran. · View Herald Transcript

glebius requested review of this revision.Sep 9 2023, 4:21 AM

Harbormaster completed remote builds in B53516: Diff 127165.Sep 9 2023, 4:21 AM

Please include why this is needed always in the commit message because this is counter intuitive to me and I think contradicts review feedback I got originally.

This revision is now accepted and ready to land.Sep 9 2023, 4:27 AM

Closed by commit rGd13550f0c9c2: stand/loader.efi: fix regression with ignoring nvstore (authored by glebius). · Explain WhySep 11 2023, 6:06 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGd13550f0c9c2: stand/loader.efi: fix regression with ignoring nvstore.

imp added a commit: rGebdd5d72fffc: stand/loader.efi: fix regression with ignoring nvstore.Apr 16 2024, 2:35 AM

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

2 lines

Diff 127237

stand/efi/loader/main.c

Loading...