hyperv/vmbus: Flip a message to only be emitted on failure
ClosedPublic
Actions

Authored by lwhsu on Sep 8 2023, 7:45 PM.

Details

Reviewers

whu
schakrabarti_microsoft.com
mhorne

Commits

rG4196186dbfd0: hyperv/vmbus: Flip a message to only be emitted on failure

Summary

This message is not very useful when things are working well.
Flip its meaning and let it only be emitted on failure.

While here, pet style(9).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 53509
Build 50400: arc lint + arc unit

Event Timeline

lwhsu created this revision.Sep 8 2023, 7:45 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 8 2023, 7:45 PM

lwhsu requested review of this revision.Sep 8 2023, 7:45 PM

Harbormaster completed remote builds in B53508: Diff 127130.Sep 8 2023, 7:45 PM

mhorne added a subscriber: mhorne.Sep 8 2023, 8:02 PM

mhorne added inline comments.

sys/dev/hyperv/pcib/vmbus_pcib.c
1708–1710	This is the correct application of style(9) here.

Really pet style(9).

Harbormaster completed remote builds in B53509: Diff 127131.Sep 8 2023, 8:37 PM

lwhsu marked an inline comment as done.Sep 8 2023, 8:37 PM

mhorne accepted this revision.Sep 8 2023, 9:02 PM

This revision is now accepted and ready to land.Sep 8 2023, 9:02 PM

LGTM

Closed by commit rG4196186dbfd0: hyperv/vmbus: Flip a message to only be emitted on failure (authored by lwhsu). · Explain WhySep 11 2023, 8:55 AM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rG4196186dbfd0: hyperv/vmbus: Flip a message to only be emitted on failure.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hyperv/

pcib/

vmbus_pcib.c

6 lines

Diff 127131

View Options

sys/dev/hyperv/pcib/vmbus_pcib.c

hyperv/vmbus: Flip a message to only be emitted on failureClosedPublicActions