Page MenuHomeFreeBSD

unifdef: Handle redefined symbols correctly.
ClosedPublic

Authored by des on Sep 6 2023, 5:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 24 2024, 3:29 AM
Unknown Object (File)
Jan 17 2024, 2:15 AM
Unknown Object (File)
Jan 3 2024, 12:37 PM
Unknown Object (File)
Dec 22 2023, 11:15 PM
Unknown Object (File)
Dec 12 2023, 1:08 PM
Unknown Object (File)
Nov 3 2023, 10:50 PM
Unknown Object (File)
Oct 14 2023, 2:50 AM
Unknown Object (File)
Sep 25 2023, 7:29 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Sep 6 2023, 5:44 AM
kevans added inline comments.
contrib/unifdef/unifdef.c
1560

This seems reasonable... I kind of wish the manpage defined solid expectations for what to do with -D/-U/-i (even if that expectation is just "last one for a name wins").

Do we want the below debugsym to still output "addsym" for symbols, or do we want "updatesym" or some such to reflect that it's a multiply-listed option?

contrib/unifdef/unifdef.c
1560

"what to do with" -> "what to do with multiple occurrences of"

Oh, but what's here looks fine otherwise... the manpage is a punt-able problem

This revision is now accepted and ready to land.Sep 6 2023, 5:04 PM

say "updsym" instead of "addsym" when redefining

This revision now requires review to proceed.Sep 6 2023, 5:08 PM
des marked 2 inline comments as done.Sep 6 2023, 5:08 PM
This revision is now accepted and ready to land.Sep 6 2023, 5:10 PM
This revision was automatically updated to reflect the committed changes.