Page MenuHomeFreeBSD
Differential D41749

Record completed SYSINITs
ClosedPublic
Actions

Authored by cperciva on Sep 5 2023, 11:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 2:06 AM
Unknown Object (File)
Wed, Oct 23, 5:11 AM
Unknown Object (File)
Sat, Oct 19, 11:57 AM
Unknown Object (File)
Oct 7 2024, 3:54 AM
Unknown Object (File)
Oct 7 2024, 3:54 AM
Unknown Object (File)
Oct 7 2024, 3:54 AM
Unknown Object (File)
Oct 7 2024, 3:54 AM
Unknown Object (File)
Oct 7 2024, 3:33 AM
View All 45 Files
Subscribers
imp

Details

Reviewers
jhb
gallatin
Commits
rG81be13da3ecf: init_main: Record completed SYSINITs
rGc31f2b5e6b59: init_main: Record completed SYSINITs
rG1926d5cef6ea: init_main: Record completed SYSINITs
Summary

When removing them from sysinit_list, append them to sysinit_done_list;
print this list from 'show sysinit' along with the list of future
sysinits.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53475
Build 50366: arc lint + arc unit

Event Timeline

cperciva created this revision.Sep 5 2023, 11:48 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 5 2023, 11:48 PM
cperciva requested review of this revision.Sep 5 2023, 11:48 PM
cperciva added a parent revision: D41748: init_main: Switch from SLIST to STAILQ, fix order.
Harbormaster completed remote builds in B53454: Diff 126922.Sep 5 2023, 11:48 PM
gallatin accepted this revision.Sep 6 2023, 4:46 AM
This revision is now accepted and ready to land.Sep 6 2023, 4:46 AM
jhb accepted this revision.Sep 6 2023, 3:11 PM
jhb added inline comments.
sys/kern/init_main.c
913

Otherwise you still print a single pending sysinit after a break.

cperciva added inline comments.Sep 6 2023, 6:33 PM
sys/kern/init_main.c
913

Thanks, will fix.

cperciva updated this revision to Diff 126981.Sep 6 2023, 6:35 PM

s/break/return/ per jhb's comment

This revision now requires review to proceed.Sep 6 2023, 6:35 PM
Harbormaster completed remote builds in B53475: Diff 126981.Sep 6 2023, 6:35 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2023, 6:37 PM
Closed by commit rG1926d5cef6ea: init_main: Record completed SYSINITs (authored by cperciva). · Explain Why
This revision was automatically updated to reflect the committed changes.
cperciva added a commit: rG1926d5cef6ea: init_main: Record completed SYSINITs.
cperciva added a commit: rGc31f2b5e6b59: init_main: Record completed SYSINITs.Sep 13 2023, 3:48 PM
cperciva added a commit: rG81be13da3ecf: init_main: Record completed SYSINITs.Sep 13 2023, 8:04 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
10 lines

Diff 126981

View Options

sys/kern/init_main.c

Loading...